Skip to content

add ember-table#1042

Merged
KevinVandy merged 3 commits into
mainfrom
ember
Jul 12, 2026
Merged

add ember-table#1042
KevinVandy merged 3 commits into
mainfrom
ember

Conversation

@KevinVandy

@KevinVandy KevinVandy commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added Ember as a supported framework option with matching branding.
    • Enabled Ember to appear in framework filtering, labeling, and library listings.
  • Updates
    • Improved the ordering of frameworks in the browse experience using per-framework usage signals, keeping “vanilla” last.
    • Refreshed TanStack Table’s description and included Ember in its framework support.
  • Bug Fixes
    • Better language detection for code blocks based on .gjs/.gts file types.
  • Tests
    • Added coverage for framework ordering behavior.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds Ember to framework types, selector options, labels, metadata, file handling, and TanStack Table’s supported framework list. Library browse routes now order visible frameworks by library counts while keeping vanilla last.

Changes

Ember framework support

Layer / File(s) Summary
Framework registration
src/libraries/types.ts, src/libraries/frameworks.tsx, src/utils/llms.ts, src/utils/npm-packages.ts, src/libraries/libraries.ts
Registers ember in framework types, selector options, labels, metadata, and TanStack Table’s framework list.
Ember file support
src/components/FileExplorer.tsx, src/components/markdown/codeBlock.shared.tsx
Maps .gjs and .gts files to the Ember icon and JavaScript or TypeScript code-block languages.
Framework browse ordering
src/routes/-libraries-utils.ts, src/routes/libraries.tsx, src/routes/libraries_.$framework.tsx, tests/libraries-utils.test.ts
Sorts visible frameworks by library counts, keeps vanilla last, applies the ordering in both library routes, and tests the result without mutating inputs.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: ladybluenotes, tkdodo, alemtuzlak

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change: adding Ember/TanStack Table support and related framework metadata updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ember

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 12, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com ad54cca Commit Preview URL

Branch Preview URL
Jul 12 2026, 06:26 PM

@KevinVandy KevinVandy merged commit 53a90ef into main Jul 12, 2026
7 checks passed
@KevinVandy KevinVandy deleted the ember branch July 12, 2026 18:26

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/markdown/codeBlock.shared.tsx (1)

84-87: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider consolidating gts/gjs into the existing array checks for consistency.

Lines 84–85 use ['cts', 'mts'].includes(ext) and ['cjs', 'mjs'].includes(ext), while the new gts/gjs checks use separate === comparisons. Merging them keeps the pattern uniform.

♻️ Optional consolidation
   if (['cts', 'mts'].includes(ext)) return 'ts'
   if (['cjs', 'mjs'].includes(ext)) return 'js'
-  if (ext === 'gts') return 'ts'
-  if (ext === 'gjs') return 'js'
+  if (['cts', 'mts', 'gts'].includes(ext)) return 'ts'
+  if (['cjs', 'mjs', 'gjs'].includes(ext)) return 'js'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/markdown/codeBlock.shared.tsx` around lines 84 - 87,
Consolidate the gts and gjs extensions into the existing array-based checks in
the extension-mapping logic, updating the TypeScript and JavaScript arrays used
by the ext conditionals. Remove the separate ext === 'gts' and ext === 'gjs'
branches while preserving their current mappings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/markdown/codeBlock.shared.tsx`:
- Around line 84-87: Consolidate the gts and gjs extensions into the existing
array-based checks in the extension-mapping logic, updating the TypeScript and
JavaScript arrays used by the ext conditionals. Remove the separate ext ===
'gts' and ext === 'gjs' branches while preserving their current mappings.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4da8f8f8-8151-4910-9318-852dd7084a51

📥 Commits

Reviewing files that changed from the base of the PR and between f44949a and ad54cca.

📒 Files selected for processing (6)
  • src/components/FileExplorer.tsx
  • src/components/markdown/codeBlock.shared.tsx
  • src/routes/-libraries-utils.ts
  • src/routes/libraries.tsx
  • src/routes/libraries_.$framework.tsx
  • tests/libraries-utils.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants