chore(deps): bump @playwright/test to ^1.61.0 across the workspace#7772
chore(deps): bump @playwright/test to ^1.61.0 across the workspace#7772plauclair-nesto wants to merge 1 commit into
Conversation
Updates the @playwright/test version in the pnpm workspace catalog and in every e2e package.json to ^1.61.0. The previously pinned version stalls on arm64 architectures. Upgrading resolves the stalling issue.
📝 WalkthroughWalkthroughPlaywright test dependencies were upgraded to ChangesPlaywright dependency update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
e2e/react-router/basic-react-query-file-based/package.json (1)
27-27: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winVersion bump is consistent with the workspace catalog.
The
^1.61.0range matches the catalog entry inpnpm-workspace.yaml. Consider using pnpm's catalog protocol ("catalog:") instead of hardcoding the version in each e2e package.json. This would centralize future Playwright version bumps to a single line inpnpm-workspace.yamlrather than requiring updates across 100+ package.json files.♻️ Suggested change: use catalog protocol
- "`@playwright/test`": "^1.61.0", + "`@playwright/test`": "catalog:",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@e2e/react-router/basic-react-query-file-based/package.json` at line 27, Replace the hardcoded `@playwright/test` version in the package manifest with the pnpm catalog protocol, using "catalog:" so its version is managed centrally by the workspace catalog.e2e/vue-router/rspack-basic-file-based/package.json (1)
19-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider using pnpm
catalog:protocol to centralize version management.The workspace catalog in
pnpm-workspace.yamlalready defines@playwright/test: ^1.61.0, yet each individual e2e package hardcodes the same range. Using thecatalog:protocol (e.g.,"@playwright/test": "catalog:") would let future bumps update onlypnpm-workspace.yamlinstead of 100+ package.json files. This is an optional improvement — only adopt if the repo doesn't already rely on explicit version strings elsewhere (e.g., for publishing or tooling).♻️ Optional refactor example
- "`@playwright/test`": "^1.61.0", + "`@playwright/test`": "catalog:",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@e2e/vue-router/rspack-basic-file-based/package.json` at line 19, Replace the hardcoded `@playwright/test` version in the package manifest with the pnpm catalog: protocol, after confirming this package is not required to retain an explicit version for publishing or tooling; use the existing workspace catalog entry as the single source of truth.pnpm-workspace.yaml (1)
43-43: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
catalog:for@playwright/testin the e2e package.json files. The version is already centralized inpnpm-workspace.yaml, so switching the e2e manifests from^1.61.0tocatalog:would remove 115 repeated pins and make future bumps a single-file change.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pnpm-workspace.yaml` at line 43, The `@playwright/test` dependency is duplicated with explicit versions across e2e package.json manifests. Replace each e2e manifest’s `@playwright/test` version with catalog: so it resolves from the centralized pnpm-workspace.yaml catalog entry, while leaving the catalog version unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@e2e/react-router/basic-react-query-file-based/package.json`:
- Line 27: Replace the hardcoded `@playwright/test` version in the package
manifest with the pnpm catalog protocol, using "catalog:" so its version is
managed centrally by the workspace catalog.
In `@e2e/vue-router/rspack-basic-file-based/package.json`:
- Line 19: Replace the hardcoded `@playwright/test` version in the package
manifest with the pnpm catalog: protocol, after confirming this package is not
required to retain an explicit version for publishing or tooling; use the
existing workspace catalog entry as the single source of truth.
In `@pnpm-workspace.yaml`:
- Line 43: The `@playwright/test` dependency is duplicated with explicit versions
across e2e package.json manifests. Replace each e2e manifest’s `@playwright/test`
version with catalog: so it resolves from the centralized pnpm-workspace.yaml
catalog entry, while leaving the catalog version unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 19c99ccd-ab70-4a7f-bf1c-c1ae76265d7b
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (116)
e2e/react-router/basepath-file-based/package.jsone2e/react-router/basic-esbuild-file-based/package.jsone2e/react-router/basic-file-based-code-splitting/package.jsone2e/react-router/basic-file-based/package.jsone2e/react-router/basic-react-query-file-based/package.jsone2e/react-router/basic-react-query/package.jsone2e/react-router/basic-scroll-restoration/package.jsone2e/react-router/basic-virtual-file-based/package.jsone2e/react-router/basic-virtual-named-export-config-file-based/package.jsone2e/react-router/basic/package.jsone2e/react-router/escaped-special-strings/package.jsone2e/react-router/generator-cli-only/package.jsone2e/react-router/i18n-paraglide/package.jsone2e/react-router/js-only-file-based/package.jsone2e/react-router/match-params/package.jsone2e/react-router/rspack-basic-file-based/package.jsone2e/react-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/react-router/scroll-restoration-sandbox-vite/package.jsone2e/react-router/sentry-integration/package.jsone2e/react-router/view-transitions/package.jsone2e/react-start/basic-auth/package.jsone2e/react-start/basic-cloudflare/package.jsone2e/react-start/basic-react-query/package.jsone2e/react-start/basic/package.jsone2e/react-start/clerk-basic/package.jsone2e/react-start/csp/package.jsone2e/react-start/css-inline/package.jsone2e/react-start/css-modules/package.jsone2e/react-start/custom-basepath/package.jsone2e/react-start/custom-server-rsbuild/package.jsone2e/react-start/dev-ssr-styles/package.jsone2e/react-start/early-hints/package.jsone2e/react-start/hmr/package.jsone2e/react-start/i18n-paraglide/package.jsone2e/react-start/import-protection-custom-config/package.jsone2e/react-start/import-protection/package.jsone2e/react-start/query-integration/package.jsone2e/react-start/rsc-deferred-hydration/package.jsone2e/react-start/rsc-query/package.jsone2e/react-start/rsc-rsbuild/package.jsone2e/react-start/rsc/package.jsone2e/react-start/scroll-restoration/package.jsone2e/react-start/server-functions-global-middleware/package.jsone2e/react-start/server-functions/package.jsone2e/react-start/server-routes-global-middleware/package.jsone2e/react-start/server-routes/package.jsone2e/react-start/split-base-and-basepath/package.jsone2e/react-start/start-manifest/package.jsone2e/react-start/static-server-functions/package.jsone2e/react-start/streaming-ssr/package.jsone2e/react-start/transform-asset-urls/package.jsone2e/react-start/virtual-routes/package.jsone2e/react-start/website/package.jsone2e/solid-router/basepath-file-based/package.jsone2e/solid-router/basic-esbuild-file-based/package.jsone2e/solid-router/basic-file-based-code-splitting/package.jsone2e/solid-router/basic-file-based/package.jsone2e/solid-router/basic-scroll-restoration/package.jsone2e/solid-router/basic-solid-query-file-based/package.jsone2e/solid-router/basic-solid-query/package.jsone2e/solid-router/basic-virtual-file-based/package.jsone2e/solid-router/basic-virtual-named-export-config-file-based/package.jsone2e/solid-router/basic/package.jsone2e/solid-router/generator-cli-only/package.jsone2e/solid-router/js-only-file-based/package.jsone2e/solid-router/rspack-basic-file-based/package.jsone2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/solid-router/scroll-restoration-sandbox-vite/package.jsone2e/solid-router/sentry-integration/package.jsone2e/solid-router/view-transitions/package.jsone2e/solid-start/basic-auth/package.jsone2e/solid-start/basic-cloudflare/package.jsone2e/solid-start/basic-solid-query/package.jsone2e/solid-start/basic/package.jsone2e/solid-start/csp/package.jsone2e/solid-start/css-modules/package.jsone2e/solid-start/custom-basepath/package.jsone2e/solid-start/query-integration/package.jsone2e/solid-start/scroll-restoration/package.jsone2e/solid-start/server-functions/package.jsone2e/solid-start/server-routes/package.jsone2e/solid-start/solid-query-layout-suspense/package.jsone2e/solid-start/start-manifest/package.jsone2e/solid-start/virtual-routes/package.jsone2e/solid-start/website/package.jsone2e/vue-router/basepath-file-based/package.jsone2e/vue-router/basic-esbuild-file-based/package.jsone2e/vue-router/basic-file-based-jsx/package.jsone2e/vue-router/basic-file-based-sfc/package.jsone2e/vue-router/basic-scroll-restoration/package.jsone2e/vue-router/basic-virtual-file-based/package.jsone2e/vue-router/basic-virtual-named-export-config-file-based/package.jsone2e/vue-router/basic-vue-query-file-based/package.jsone2e/vue-router/basic-vue-query/package.jsone2e/vue-router/basic/package.jsone2e/vue-router/generator-cli-only/package.jsone2e/vue-router/js-only-file-based/package.jsone2e/vue-router/rspack-basic-file-based/package.jsone2e/vue-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/vue-router/scroll-restoration-sandbox-vite/package.jsone2e/vue-router/sentry-integration/package.jsone2e/vue-router/view-transitions/package.jsone2e/vue-start/basic-auth/package.jsone2e/vue-start/basic-cloudflare/package.jsone2e/vue-start/basic-vue-query/package.jsone2e/vue-start/basic/package.jsone2e/vue-start/css-modules/package.jsone2e/vue-start/custom-basepath/package.jsone2e/vue-start/query-integration/package.jsone2e/vue-start/scroll-restoration/package.jsone2e/vue-start/server-functions/package.jsone2e/vue-start/server-routes/package.jsone2e/vue-start/start-manifest/package.jsone2e/vue-start/virtual-routes/package.jsone2e/vue-start/website/package.jsonpnpm-workspace.yaml
|
View your CI Pipeline Execution ↗ for commit c56b9dc
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
We investigated the tanstack-start-example-rscs:build failure and determined it is unrelated to this PR's changes. The error stems from a pre-existing incompatibility between nitro-nightly and the installed nitro package, where the ./runtime/meta subpath is not exported — no nitro-related files were touched by the playwright version bump.
No code changes were suggested for this issue.
You can trigger a rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
1 participant
Updates the @playwright/test version in the pnpm workspace catalog and in every e2e package.json to ^1.61.0.
The previously pinned version stalls on arm64 architectures. Upgrading resolves the stalling issue.
Summary by CodeRabbit