test({vue,angular}-query): pin the reactive refetch call with 'toHaveBeenNthCalledWith'#11051
Open
sukvvon wants to merge 1 commit into
Open
test({vue,angular}-query): pin the reactive refetch call with 'toHaveBeenNthCalledWith'#11051sukvvon wants to merge 1 commit into
sukvvon wants to merge 1 commit into
Conversation
…BeenNthCalledWith'
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesQuery call assertions
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 65936f1
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
In these tests, a reactive query key is changed and the query is refetched, so
queryFnfires twice: first with the old key, then with the new key. The second call — the one that proves the reactive update reached the refetch — was asserted with order-agnostictoHaveBeenCalledWith, which would also pass if only the first call carried the new key.Switching to
toHaveBeenNthCalledWith(2, ...)pins the assertion to the second call, so it verifies the new key is used specifically on the refetch after the key changed.vue-query/useQuery—keyRefchanged thenrefetch()angular-query-experimental/inject-query— key signal changed then re-run (the inline comment already states the intent is "the new queryKey")✅ Checklist
🚀 Release Impact
Summary by CodeRabbit