Skip to content

test({react,preact,solid}-query/useMutation): improve callback assertions with 'toHaveBeenNthCalledWith' #11050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 1 commit into from
Jul 11, 2026
+54 −36
Merged

test({react,preact,solid}-query/useMutation): improve callback assertions with 'toHaveBeenNthCalledWith' #11050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions packages/preact-query/src/__tests__/useMutation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,15 +463,15 @@ describe('useMutation', () => {
expect(getByRole('heading').textContent).toBe('3')
expect(onSuccessMock).toHaveBeenCalledTimes(3)

expect(onSuccessMock).toHaveBeenCalledWith(1)
expect(onSuccessMock).toHaveBeenCalledWith(2)
expect(onSuccessMock).toHaveBeenCalledWith(3)
expect(onSuccessMock).toHaveBeenNthCalledWith(1, 1)
expect(onSuccessMock).toHaveBeenNthCalledWith(2, 2)
expect(onSuccessMock).toHaveBeenNthCalledWith(3, 3)

expect(onSettledMock).toHaveBeenCalledTimes(3)

expect(onSettledMock).toHaveBeenCalledWith(1)
expect(onSettledMock).toHaveBeenCalledWith(2)
expect(onSettledMock).toHaveBeenCalledWith(3)
expect(onSettledMock).toHaveBeenNthCalledWith(1, 1)
expect(onSettledMock).toHaveBeenNthCalledWith(2, 2)
expect(onSettledMock).toHaveBeenNthCalledWith(3, 3)
})

it('should set correct values for `failureReason` and `failureCount` on multiple mutate calls', async () => {
Expand Down Expand Up @@ -568,24 +568,30 @@ describe('useMutation', () => {
await vi.advanceTimersByTimeAsync(0)
expect(getByRole('heading').textContent).toBe('3')
expect(onErrorMock).toHaveBeenCalledTimes(3)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
1,
'Expected mock error. All is well! 1',
)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
2,
'Expected mock error. All is well! 2',
)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
3,
'Expected mock error. All is well! 3',
)

expect(onSettledMock).toHaveBeenCalledTimes(3)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
1,
'Expected mock error. All is well! 1',
)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
2,
'Expected mock error. All is well! 2',
)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
3,
'Expected mock error. All is well! 3',
)
})
Expand Down
30 changes: 18 additions & 12 deletions packages/react-query/src/__tests__/useMutation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,15 +462,15 @@ describe('useMutation', () => {
expect(getByRole('heading').textContent).toBe('3')
expect(onSuccessMock).toHaveBeenCalledTimes(3)

expect(onSuccessMock).toHaveBeenCalledWith(1)
expect(onSuccessMock).toHaveBeenCalledWith(2)
expect(onSuccessMock).toHaveBeenCalledWith(3)
expect(onSuccessMock).toHaveBeenNthCalledWith(1, 1)
expect(onSuccessMock).toHaveBeenNthCalledWith(2, 2)
expect(onSuccessMock).toHaveBeenNthCalledWith(3, 3)

expect(onSettledMock).toHaveBeenCalledTimes(3)

expect(onSettledMock).toHaveBeenCalledWith(1)
expect(onSettledMock).toHaveBeenCalledWith(2)
expect(onSettledMock).toHaveBeenCalledWith(3)
expect(onSettledMock).toHaveBeenNthCalledWith(1, 1)
expect(onSettledMock).toHaveBeenNthCalledWith(2, 2)
expect(onSettledMock).toHaveBeenNthCalledWith(3, 3)
})

it('should set correct values for `failureReason` and `failureCount` on multiple mutate calls', async () => {
Expand Down Expand Up @@ -567,24 +567,30 @@ describe('useMutation', () => {
await vi.advanceTimersByTimeAsync(0)
expect(getByRole('heading').textContent).toBe('3')
expect(onErrorMock).toHaveBeenCalledTimes(3)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
1,
'Expected mock error. All is well! 1',
)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
2,
'Expected mock error. All is well! 2',
)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
3,
'Expected mock error. All is well! 3',
)

expect(onSettledMock).toHaveBeenCalledTimes(3)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
1,
'Expected mock error. All is well! 1',
)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
2,
'Expected mock error. All is well! 2',
)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
3,
'Expected mock error. All is well! 3',
)
})
Expand Down
30 changes: 18 additions & 12 deletions packages/solid-query/src/__tests__/useMutation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,15 +472,15 @@ describe('useMutation', () => {

expect(onSuccessMock).toHaveBeenCalledTimes(3)

expect(onSuccessMock).toHaveBeenCalledWith(1)
expect(onSuccessMock).toHaveBeenCalledWith(2)
expect(onSuccessMock).toHaveBeenCalledWith(3)
expect(onSuccessMock).toHaveBeenNthCalledWith(1, 1)
expect(onSuccessMock).toHaveBeenNthCalledWith(2, 2)
expect(onSuccessMock).toHaveBeenNthCalledWith(3, 3)

expect(onSettledMock).toHaveBeenCalledTimes(3)

expect(onSettledMock).toHaveBeenCalledWith(1)
expect(onSettledMock).toHaveBeenCalledWith(2)
expect(onSettledMock).toHaveBeenCalledWith(3)
expect(onSettledMock).toHaveBeenNthCalledWith(1, 1)
expect(onSettledMock).toHaveBeenNthCalledWith(2, 2)
expect(onSettledMock).toHaveBeenNthCalledWith(3, 3)
})

it('should set correct values for `failureReason` and `failureCount` on multiple mutate calls', async () => {
Expand Down Expand Up @@ -589,24 +589,30 @@ describe('useMutation', () => {
expect(rendered.getByRole('heading').textContent).toBe('3')

expect(onErrorMock).toHaveBeenCalledTimes(3)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
1,
'Expected mock error. All is well! 1',
)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
2,
'Expected mock error. All is well! 2',
)
expect(onErrorMock).toHaveBeenCalledWith(
expect(onErrorMock).toHaveBeenNthCalledWith(
3,
'Expected mock error. All is well! 3',
)

expect(onSettledMock).toHaveBeenCalledTimes(3)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
1,
'Expected mock error. All is well! 1',
)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
2,
'Expected mock error. All is well! 2',
)
expect(onSettledMock).toHaveBeenCalledWith(
expect(onSettledMock).toHaveBeenNthCalledWith(
3,
'Expected mock error. All is well! 3',
)
})
Expand Down
Loading