test(query-core/utils,vue-query/mutationOptions): assert reference identity with 'toBe'#11048
Merged
Merged
Conversation
…entity with 'toBe'
|
View your CI Pipeline Execution ↗ for commit 794dc88
☁️ Nx Cloud last updated this comment at |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTests for ChangesReference identity tests
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
keepPreviousDataandmutationOptionsare pure pass-through helpers that return the exact same reference they receive (return previousData/return options). Their tests asserted the return value withtoEqual/toStrictEqual, which only compares by value — so they would still pass even if the helper wrongly returned a copy (e.g.{ ...options }), missing the "return as is" contract. This switches them totoBe, which asserts reference identity — the actual contract.keepPreviousData(query-core) — test title is literally "should return the parameter as is"mutationOptions(vue-query) — aligns with the other frameworks, whose*Optionstests already usetoBe(test({react,preact,angular}-query/{queryOptions,infiniteQueryOptions,mutationOptions}): replace 'toStrictEqual' with 'toBe' and add type annotations #10192, test({solid,svelte}-query/mutationOptions): replace 'toStrictEqual' with 'toBe' for identity check #10407)✅ Checklist
🚀 Release Impact
Summary by CodeRabbit