fix(query-devtools/Devtools): correct the Theme sub-trigger className from 'position' to 'theme'#10811
Open
sukvvon wants to merge 2 commits into
Open
fix(query-devtools/Devtools): correct the Theme sub-trigger className from 'position' to 'theme'#10811sukvvon wants to merge 2 commits into
sukvvon wants to merge 2 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR fixes a CSS class name for the Devtools settings Theme sub-trigger, updating component and tests to use ChangesTheme sub-trigger CSS class correction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit eca1d82
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 23 bumped as dependents. 🟩 Patch bumps
|
… from 'position' to 'theme'
sukvvon
force-pushed
the
fix/query-devtools-theme-subtrigger-classname
branch
from
eca1d82 to
520463b
Compare
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The Theme sub-trigger in the devtools settings menu carried the marker class
tsqd-settings-menu-sub-trigger-position— the same class the Position sub-trigger already uses (Devtools.tsx:1114vsDevtools.tsx:1195). Both sub-triggers therefore matched any consumer rule targeting.tsqd-settings-menu-sub-trigger-position, and.tsqd-settings-menu-sub-trigger-themematched nothing at all, so the two sub-triggers could not be styled independently from user CSS.Rename the Theme sub-trigger's marker class to
tsqd-settings-menu-sub-trigger-theme, lining it up with the existing-positionand-disabled-queriesmarkers (each derived from the sub-trigger's visible label).Also tighten the two
settings menucases that exercise the Theme sub-trigger:.tsqd-settings-menu-sub-triggerelement and filter bytextContentbecause the class collision made a direct selector ambiguous. With the marker class fixed, both cases now query.tsqd-settings-menu-sub-trigger-themedirectly..tsqd-settings-menu-sub-trigger-position, so a future revert that puts the class back on Theme would fail loudly here instead of silently re-collapsing the two triggers.✅ Checklist
🚀 Release Impact
Summary by CodeRabbit