test(preact-query/useQueries): add test for not fetching during restoring period when 'isRestoring' is true by sukvvon · Pull Request #10197 · TanStack/query

sukvvon · 2026-02-27T02:32:12Z

🎯 Changes

Add tests to cover the isRestoring branch in useQueries.ts (lines 235, 271).

When IsRestoringProvider provides true, queries should remain in pending status with fetchStatus: 'idle' and never call queryFn, even after the query's sleep duration has elapsed.

Two test cases added:

Queries with the same duration should not fetch during the restoring period
Queries with different durations should not fetch during the restoring period

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage for useQueries behavior during restore periods, ensuring queries remain in pending state without unnecessary fetches.

…ring period when 'isRestoring' is true

changeset-bot · 2026-02-27T02:32:17Z

⚠️ No Changeset found

Latest commit: ed29a4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-27T02:32:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0da627b and ed29a4b.

📒 Files selected for processing (1)

packages/preact-query/src/__tests__/useQueries.test.tsx

📝 Walkthrough

Walkthrough

This PR adds test coverage to verify that the useQueries hook does not initiate any fetch operations during the isRestoring period. Two test cases validate that queries remain pending with idle fetchStatus and undefined data while restoration is active, using IsRestoringProvider to simulate the restoration state.

Changes

Cohort / File(s)	Summary
Test Coverage for isRestoring Behavior `packages/preact-query/src/__tests__/useQueries.test.tsx`	Adds two test cases verifying that useQueries does not trigger fetches during isRestoring period. Tests assert that queries remain pending with idle fetchStatus and no data, and that queryFn is never invoked during restoration with both consistent and varying query durations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

test(solid-query/useQuery): add test for 'isRestoring' transition from true to false triggering refetch #10168 — Adds similar tests for isRestoring behavior using IsRestoringProvider across the query codebase.
test(preact-query/useQuery): add test for not fetching during restoring period when 'isRestoring' is true #10180 — Adds tests asserting no fetch occurs during isRestoring period for useQuery hook, mirroring the same restoration behavior validation.
feat: Preact Adapter #9935 — Preact Adapter PR that introduces IsRestoringProvider and the useQueries implementation being tested in this PR.

Suggested reviewers

TkDodo
manudeli

Poem

🐰 A rabbit hops through isRestoring skies,
No fetches wake—just pending, watchful eyes,
Two tests now guard the restoration way,
Keep queries calm, let data sleep all day! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding tests for useQueries behavior during the isRestoring period, which matches the test additions in the changeset.
Description check	✅ Passed	The description follows the template structure with completed sections, including detailed explanation of changes, checked checklist items, and proper release impact classification.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-02-27T02:32:39Z

View your CI Pipeline Execution ↗ for commit ed29a4b

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 47s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-27 02:35:07 UTC

pkg-pr-new · 2026-02-27T02:33:54Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10197

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10197

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10197

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10197

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10197

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10197

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10197

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10197

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10197

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10197

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10197

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10197

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10197

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10197

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10197

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10197

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10197

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10197

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10197

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10197

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10197

commit: ed29a4b

test(preact-query/useQueries): add test for not fetching during resto…

ed29a4b

…ring period when 'isRestoring' is true

github-actions bot added the package: preact-query label Feb 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(preact-query/useQueries): add test for not fetching during restoring period when 'isRestoring' is true#10197

test(preact-query/useQueries): add test for not fetching during restoring period when 'isRestoring' is true#10197
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/preact-query-useQueries-isRestoring

sukvvon commented Feb 27, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 27, 2026

Uh oh!

coderabbitai bot commented Feb 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Feb 27, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Feb 27, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Feb 27, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 27, 2026 •

edited

Loading

nx-cloud bot commented Feb 27, 2026 •

edited

Loading