Skip to content

Conversation

@ignatz
Copy link
Contributor

@ignatz ignatz commented Jan 7, 2026

…n package

Based on #1090 by @MentalGear.

🎯 Changes

Add a syncMode option to the TrailBase collection and adopt e2e tests in line with e.g. electric's.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: b39e8a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ignatz ignatz force-pushed the tb-e2e branch 2 times, most recently from 3d1226e to 06ae6e3 Compare January 7, 2026 19:36
…n package

Based on TanStack#1090 by @MentalGear.

Co-authored-by: MentalGear <2837147+MentalGear@users.noreply.github.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 16, 2026

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@1098

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@1098

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@1098

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@1098

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@1098

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1098

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@1098

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@1098

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1098

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@1098

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@1098

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1098

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@1098

commit: b39e8a7

@MentalGear
Copy link

MentalGear commented Jan 19, 2026 via email

@ignatz
Copy link
Contributor Author

ignatz commented Jan 20, 2026

Could you maybe precise what partial support for on-demand means?

I'd rather not :hide:. This change should be seen in the broader context of: #1101, which actually adds full support. "Partial" should be read here as just enough to get the mandatory e2e tests working, while being basically broken. In practice the e2e tests make many insufficient assertions, e.g. on filter queries they will only assert that something is being returned, not "what" is being returned.

@MentalGear
Copy link

OK thank you for the honest assessment !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants