Using an enum custom type to declare string constants#4
Draft
jbarrett wants to merge 1 commit intoTamarou:pufrom
Draft
Using an enum custom type to declare string constants#4jbarrett wants to merge 1 commit intoTamarou:pufrom
jbarrett wants to merge 1 commit intoTamarou:pufrom
Conversation
Member
|
I've converted this to a draft so I don't forget that it's not ready to go in yet. I'll have a look sometime between now and TPRC and see what I can do with it. |
This is not yet working - the enum constructor expects the occasional aligning value, then a list of strings which it increments the value for. I tried coercing all the values to arrayrefs with pair, but the constructor is unhappy with this. It should at least show off how this *should* work. The parameter to your FFI bound function should now be a string, e.g. 'KEY_A', and functions can also be coerced into returning string constants - see return type for `GetKeyPressed`. It's not a radical departure API-wise - rlt-01.pl should reflect the required changes
Contributor
Author
|
Just revisiting this, with an eye to getting it working ... but looking again, I don't think this change is a good idea. The specific "not working" problem I had was I don't think there's a way to do this robustly. OK to close? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not yet working - the enum constructor expects the occasional aligning value, then a list of strings which it increments the value for. I tried coercing all the values to arrayrefs with pair, but the constructor is so-far unhappy with this.
It should at least show off how this should work. The parameter to your FFI bound function should now be a string, e.g. 'KEY_A', and functions can also be coerced into returning string constants - see return type for
GetKeyPressed.It's not a radical departure API-wise - rlt-01.pl should reflect the required changes from the end-user POV.
edit The main advantage of this is that you don't have to worry about importing constants into your namespace.