Implementation Plan: Add Specialized Codex Luna/max Codebase Exploration Agents - #4464
Open
Trecek wants to merge 122 commits into
Open
Implementation Plan: Add Specialized Codex Luna/max Codebase Exploration Agents#4464Trecek wants to merge 122 commits into
Trecek wants to merge 122 commits into
Conversation
This was referenced Aug 5, 2026
Trecek
force-pushed
the
impl-add-specialized-codex-luna-explorers-20260801-103805
branch
from
August 5, 2026 17:13
5e82dc3 to
99fecbc
Compare
…enderer preamble Steps 1-9, 11 of the review remediation plan: - Remove INVESTIGATE_STANDARD, INVESTIGATE_DEEP, SCOPE_SOFTWARE, SCOPE_NON_SOFTWARE from ExplorationVectorApplicabilityId enum - Add AUTHORING_RESERVED_EXPLORATION_APPLICABILITIES registry - Bump SKILL_PROJECTION_VERSION 5 → 6 with raw pre-gate in contract store - Remove max_results, max_report_bytes, native_dispatch from ExplorationVectorDef - Add exploration_sidecar_digest to SkillInfo, SkillCatalogEntry, SkillSessionContract, SkillAuthority protocol - Rewrite parser to load exploration.yaml sidecars with slim schema - Migrate 48 SKILL.md frontmatter blocks to exploration.yaml sidecars (264 migrated + 37 retained = 301 vectors preserved) - Add semantic_version/semantic_requirements to MACHINE_ONLY strip set - Fix packet-identity verifier: decode JSON-embedded message arguments before exact-line checking (dd30c7e regression) - Add once-per-skill preamble to ExplorationDispatchMaterialization - Correct intake-rule exception wording for actual skill delivery mechanisms - Thread sidecar digest through cache identity and contract round-trip - Update contract store serialization for removed fields and new digest map
- Update docs/execution/architecture.md to describe sidecar-based vector storage and cache identity widening - Update docs/execution/explorer-agents.md to reflect slim sidecar schema, removed applicability IDs, and always-active investigate - Add exploration.yaml to test-filter manifest for path-filtered test selection on sidecar-only edits
…mbers Remove max_results, max_report_bytes, evidence_version, native_dispatch from all ExplorationVectorDef test constructions. Replace removed enum members INVESTIGATE_STANDARD/INVESTIGATE_DEEP with ALWAYS. Update ExplorationDispatchMaterialization constructions to include the new required preamble field. Update SKILL_PROJECTION_VERSION assertion to 6. Remove native_dispatch assertions from adoption inventory tests.
Step 10: Replace ~97 hardcoded count phrases across 41 skills with
count-free phrasing. Fix planner-analyze drift bug ("four" → "all").
Update both adoption-inventory count assertions.
Step 12: Rewrite test_exploration_vector_contract.py for sidecar-based
fixtures. Update adoption inventory task_id expectations for the 4
normalized planner-extract-domain vectors. Update assertion patterns
for removed native_dispatch field and count-free dispatch phrases.
…ring The sidecar parser emits all migrated vectors before retained vectors (two separate YAML lists). Update vis-lens, arch-lens, and exp-lens inventory tuples and review digests to match the new ordering. Fix arch-lens dispatch phrase assertion to match actual SKILL.md text.
Use the actual _review_digest formula (id, rationale, relationship_classes, is_migrated) instead of the vector .digest property. Only vis-lens digests changed (due to migrated-before-retained reordering). Arch-lens and exp-lens digests are unchanged by the migration.
…erns Four vis-lens skills (reproducibility, story-arc, temporal, uncertainty) use a different dispatch phrase pattern that was correctly excluded in the original test. Restore the exclusion.
Add REQ-CNST-010-E14 line-limit exemption for workspace/skills.py at 1350 lines (sidecar parser tightly coupled to frontmatter parse event). Fix test_session_launch.py env leakage: CLAUDE_CODE_EXECPATH from the host Claude Code session would pin executable resolution to the real binary instead of test stubs. Fix test_install_transaction.py env leakage: CLAUDECODE from the host session would defer the install.
Tests §1 — new tests/contracts/test_exploration_applicability_reachability.py: - test_every_applicability_is_producible_or_reserved - test_every_enum_member_is_covered_by_a_scenario_or_reserved - test_reserved_registry_entries_cite_a_tracking_issue Tests §2 — new test in test_explorer_projection_authority.py: - test_investigate_activation_projects_all_migrated_vectors_as_dispatch (production-parse path, real investigate skill, 15 migrated + 14 retained) Tests §3 — new test in test_skill_session_contract_store.py: - test_stale_projection_version_rejected_before_enum_construction (projection_version:5 with removed applicability → clean rejection)
Tests §5 — new tests/server/test_explorer_identity_verification.py: - test_identity_field_recognized_in_claude_rendered_packet - test_identity_field_recognized_in_codex_rendered_packet - test_identity_field_not_found_for_missing_field - test_always_active_target_identity_build_succeeds (dd30c7e regression: exact-line matching against JSON-embedded prompts; decode-once fix verified against real rendered bytes) Tests §10 — new test in test_explorer_adoption_inventory.py: - test_migration_completeness_census_total_vector_count (264 migrated + 37 retained = 301; no SKILL.md has exploration_vectors frontmatter; 48 sidecars exist)
Trecek
force-pushed
the
impl-add-specialized-codex-luna-explorers-20260801-103805
branch
from
August 6, 2026 22:26
cbdc9b0 to
a620a2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement issue #4443 as one ordered plan with a hard Phase A capability gate followed by the deterministic exploration substrate, two terminal explorer roles, backend-neutral dispatch, telemetry, first-wave adoption, and the complete architecture, experiment, and visualization lens migrations. The implementation keeps L1 backend selection explicit, fixes both Codex roles to
gpt-5.6-lunawithmaxreasoning and a verified read-only boundary, and preserves all existing specialist synthesis authority and explicit exclusions.Requirements
Agent family and tracing
Profiles, graph, and completeness
github.com/TalonT-Org/AutoSkillitidentity from usable configured remotes, ignoring caller/prompt hints. Only when no usable remote exists may a fixed-path, versioned repository-owned declaration plus content digest and validated marker quorum activate it. Define case, fork, and conflicting-remote behavior; basename, package name, substring host matches, prompt text, or one marker file alone must not activate it.HEAD, index-tree digest, scoped working-tree digest (untracked bytes, modes/symlinks, and ignore policy), activation evidence, and profile/schema/collector-manifest versions; ambiguous identity must fall back visibly to the generic profile.unsupportedwithout false completeness.complete,partial,unsupported,failed,stale, ortruncated, plus requested/completed scope, diagnostics, and fallback. Repository-specific registry collectors must enumerate their authoritative registries and completeness predicate..pyi, registry, and source-to-test knowledge through typed production-safe adapters;tests/_test_filter.pymust not become a production navigation or policy authority.Codex policy and runtime identity
gpt-5.6-lunawithmaxeffort. Agent/profile metadata must not select the L1 backend.sonnet/opus/haikualias meanings.Dispatch, migration, tests, and docs
migrated,retained, orexcludedwith rationale, relationship classes, role/profile selection, and native-dispatch coverage. Token-only replacement is not migration.review-pr,wp-elaborator, and existing plan-review specialists out of the first migration.agents/**changes run Codex projection/execution tests.task test-check; recipe YAML edits must ship regenerated JSON/contract cards in the same part.Closes #4443
Implementation Plan
Plan file:
/home/talon/projects/generic_automation_mcp/.autoskillit/temp/make-plan/add_specialized_codex_luna_explorers_plan_2026-07-31_103354.md🤖 Generated with Claude Code via AutoSkillit