Skip to content

Implementation Plan: Remove AGENTS.md Per-File Catalogs and Retire Their Checker - #4436

Merged
Trecek merged 7 commits into
developfrom
impl-issue-4430-remove-agents-catalogs-20260730-161350
Jul 31, 2026
Merged

Implementation Plan: Remove AGENTS.md Per-File Catalogs and Retire Their Checker#4436
Trecek merged 7 commits into
developfrom
impl-issue-4430-remove-agents-catalogs-20260730-161350

Conversation

@Trecek

@Trecek Trecek commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove exhaustive per-file inventories from the repository guidance hierarchy while retaining all 63 tracked AGENTS.md guides, all 62 existing CLAUDE.md adapters, and every non-catalog instruction. Directory/package indexes and behavioral contract tables remain.

Retire scripts/check_sub_agents_md.py, its pre-commit hook, direct tests, catalog-positive assertions, module-name coverage assertion, and test-filter route. Replace those positive filename-completeness checks with tracked-file parity, catalog-absence detection, and explicit preservation canaries for Channel B, _capture isolation, guard invariants, and catalog-carried behavior.

Validation

  • pre-commit run --all-files
  • AUTOSKILLIT_TEST_BASE_REF=develop task test-filtered — 32,518 passed, 559 skipped, 27 xfailed
  • task test-all — 34,081 passed, 630 skipped, 27 xfailed

Closes #4430

Implementation Plan

Plan file: /home/talon/projects/generic_automation_mcp/.autoskillit/temp/make-plan/issue_4430_remove_agents_catalogs_plan_2026-07-30_153128.md

🤖 Generated with Codex via AutoSkillit

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Summary: 13 inline findings (4 warning, 9 info). No critical/blocking issues. See inline comments for detail. Warnings route to resolve-review.

⚠️ Outside Diff Range

These findings target lines not in the diff and could not be posted as inline comments:

src/autoskillit/cli/session/AGENTS.md

  • L385 [warning/cohesion]: Asymmetric prose preservation across CLI siblings — cli/session/AGENTS.md and cli/ui/AGENTS.md preserve critical behavio

src/autoskillit/hooks/_capture/AGENTS.md

  • L870 [info/cohesion]: hooks/_capture/AGENTS.md is a pure deletion (-21 lines, no prose preservation) while its sibling hooks/AGENTS.md and hoo

src/autoskillit/hooks/guards/AGENTS.md

  • L970 [warning/cohesion]: hooks/guards/AGENTS.md is the only file in the PR to receive a major restructure — a brand-new 33-line 'Guard Capabiliti

tests/docs/test_sub_claude_md_completeness.py

  • L2591 [warning/cohesion]: Hard-coded family and total counts in test_tracked_guidance_families_and_counts — `assert tuple(len(family) for family i

Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py Outdated
Comment thread tests/docs/test_sub_claude_md_completeness.py
Comment thread tests/docs/test_sub_claude_md_completeness.py
@Trecek
Trecek enabled auto-merge July 31, 2026 02:34
@Trecek
Trecek added this pull request to the merge queue Jul 31, 2026
Merged via the queue into develop with commit a7d3876 Jul 31, 2026
3 checks passed
@Trecek
Trecek deleted the impl-issue-4430-remove-agents-catalogs-20260730-161350 branch July 31, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant