Skip to content

fix: enforce server-owned audit authority admission - #4427

Merged
Trecek merged 24 commits into
developfrom
impl-rectify-audit-authority-20260729-205238
Jul 31, 2026
Merged

fix: enforce server-owned audit authority admission#4427
Trecek merged 24 commits into
developfrom
impl-rectify-audit-authority-20260729-205238

Conversation

@Trecek

@Trecek Trecek commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move audit authority identity ownership from child-authored artifacts to the server admission boundary
  • add durable installation, attempt, publication, finalization, replay, and disposition fencing
  • isolate standalone audit evidence and normalize audit outcome routing across recipe families
  • preserve server-authored response fields, including kill_reason, through replay and response budgeting
  • add production-seam, state-machine, fault-injection, retention, security, and architectural regression coverage

Verification

  • pre-commit run --all-files
  • task test-all — 34,230 passed, 631 skipped, 27 xfailed
  • AUTOSKILLIT_TEST_FILTER=conservative AUTOSKILLIT_TEST_BASE_REF=develop task test-check — 32,756 passed, 570 skipped, 27 xfailed
  • independent implementation re-audit: GO

Fixes #4419

Trecek
Trecek commented Jul 31, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread docs/execution/architecture.md Outdated
Comment thread src/autoskillit/recipe/_contracts_manifest.py
Comment thread src/autoskillit/core/types/_type_audit_admission.py
Comment thread src/autoskillit/core/types/_type_audit_admission.py
Comment thread src/autoskillit/server/_audit_authority_materializer.py
Comment thread src/autoskillit/core/types/_type_audit_admission.py
Trecek
Trecek commented Jul 31, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread src/autoskillit/server/tools/tools_execution.py
Comment thread tests/conftest.py
Comment thread tests/server/test_audit_cycle_delivery_integration.py
Trecek
Trecek commented Jul 31, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — completion of bisected batch (2 findings). Verdict: approved_with_comments.

Comment thread src/autoskillit/server/tools/tools_audit_artifacts.py
Comment thread src/autoskillit/server/_audit_authority_materializer.py
Trecek
Trecek commented Jul 31, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — completion of bisected batch (2 findings). Verdict: approved_with_comments.

Comment thread src/autoskillit/server/tools/tools_audit_artifacts.py
Comment thread src/autoskillit/server/_audit_authority_materializer.py
@Trecek Trecek mentioned this pull request Jul 31, 2026
Open
Trecek added 24 commits July 30, 2026 23:59
@Trecek
feat: add audit admission core contracts
5dd94f1
@Trecek
feat: register typed audit artifact producers
baac4d8
@Trecek
feat: cut over audit authority ownership
80aeccd
@Trecek
feat: isolate standalone audit evidence
68fa8f6
@Trecek
feat: normalize audit outcome routing
90bbd3c
@Trecek
test: ratchet audit authority ownership
28fdf22
@Trecek
fix: close audit authority ownership gaps
50e54a3
@Trecek
fix(review): correct headless tool documentation count
7285631
@Trecek
fix(review): remove unused prepared-effect status
3951113
@Trecek
fix(review): centralize audit contract validators
34b295e
@Trecek
fix(review): contain standalone evidence rereads
c5dc43d
@Trecek
fix(review): reuse admission validators within file cap
d6a58de
@Trecek
fix(review): assert the TOCTOU rejection type
63549f6
@Trecek
fix(review): decouple standalone schema validation
76b4391
@Trecek
fix(review): correct the headless tool count
e42a7a3
@Trecek
fix(review): remove the unused storage failure reason
4338998
@Trecek
fix(review): make reservation handle digests unique
5d1dd3b
@Trecek
fix(review): remove unreachable materialization states
09388bb
@Trecek
fix(review): remove unpersisted attempt lifecycle states
42d0202
@Trecek
fix(review): assert each TOCTOU rejection boundary
c6864f4
@Trecek
fix(review): refresh canonical consumer anchors
09c3ade
@Trecek
fix(review): skip unsupported hardlink fixtures
258f8b8
@Trecek
fix: resolve pre-commit violations
f9bbd70
@Trecek
test: account for merged delivery architecture
a4ff444
@Trecek
Trecek force-pushed the impl-rectify-audit-authority-20260729-205238 branch from 6ceea49 to a4ff444 Compare July 31, 2026 07:16
@Trecek
Trecek added this pull request to the merge queue Jul 31, 2026
Merged via the queue into develop with commit 817086f Jul 31, 2026
3 checks passed
@Trecek
Trecek deleted the impl-rectify-audit-authority-20260729-205238 branch July 31, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Trecek