Rectify: MCP Startup Readiness and Replay-Safe Kitchen Opening - #4425
Conversation
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: blocking issue detected. See the inline comments; the automated verdict is changes_requested. GitHub does not permit an author to request changes on their own PR, so this review was submitted as COMMENT.
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: blocking issue detected. See the inline comments; the automated verdict is changes_requested. GitHub does not permit an author to request changes on their own PR, so this summary was submitted as COMMENT.
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
This is a self-PR review. The following inline comments are advisory findings. 3 critical-severity issues (test hermeticity regressions) and 19 warnings must be addressed before merge. 12 info-severity findings are suggestions.
a165215 to
2c52b2b
Compare
Summary
Issue #4417 exposes two missing protocols: interactive startup lacked an owner for ensuring
open_kitchenwas addressable before dispatch, and kitchen opening lacked an explicit re-entry/reconciliation state machine after partial effects.This change adds a timeout-bounded client-readiness barrier and semantic retry policy, a typed replay-safe kitchen transition with durable effect receipts, and generalized fleet effect provenance for timeout, cancellation, crash, cleanup, and resume paths.
Verification
pre-commit run --all-filesAUTOSKILLIT_TEST_FILTER=conservative AUTOSKILLIT_TEST_BASE_REF=develop task test-checkImplementation Plan
Plan file:
.autoskillit/temp/rectify/rectify_mcp_startup_readiness_and_retry_immunity_2026-07-29_134135.md🤖 Generated with Claude Code via AutoSkillit