Skip to content

Rectify: MCP Startup Readiness and Replay-Safe Kitchen Opening - #4425

Merged
Trecek merged 55 commits into
developfrom
impl-rectify_mcp_startup_readiness_and_retry_immunity_2026-07-29_134135-20260729-164551
Jul 31, 2026
Merged

Rectify: MCP Startup Readiness and Replay-Safe Kitchen Opening#4425
Trecek merged 55 commits into
developfrom
impl-rectify_mcp_startup_readiness_and_retry_immunity_2026-07-29_134135-20260729-164551

Conversation

@Trecek

@Trecek Trecek commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Issue #4417 exposes two missing protocols: interactive startup lacked an owner for ensuring open_kitchen was addressable before dispatch, and kitchen opening lacked an explicit re-entry/reconciliation state machine after partial effects.

This change adds a timeout-bounded client-readiness barrier and semantic retry policy, a typed replay-safe kitchen transition with durable effect receipts, and generalized fleet effect provenance for timeout, cancellation, crash, cleanup, and resume paths.

Verification

  • pre-commit run --all-files
  • AUTOSKILLIT_TEST_FILTER=conservative AUTOSKILLIT_TEST_BASE_REF=develop task test-check

Implementation Plan

Plan file: .autoskillit/temp/rectify/rectify_mcp_startup_readiness_and_retry_immunity_2026-07-29_134135.md

🤖 Generated with Claude Code via AutoSkillit

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/server/tools/tools_fleet_dispatch.py
Comment thread tests/cli/test_session_launch.py Outdated
Comment thread tests/execution/backends/test_cli_conformance_probes.py
Comment thread src/autoskillit/execution/process/_process_kill.py
Comment thread src/autoskillit/fleet/_api.py
Comment thread src/autoskillit/core/types/_type_backend.py Outdated
Comment thread src/autoskillit/server/_recipe_delivery.py
Comment thread src/autoskillit/cli/_prompts.py Outdated
Comment thread src/autoskillit/fleet/state_types.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking issue detected. See the inline comments; the automated verdict is changes_requested. GitHub does not permit an author to request changes on their own PR, so this review was submitted as COMMENT.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/core/types/_type_backend.py Outdated
Comment thread src/autoskillit/execution/backends/claude.py Outdated
Comment thread src/autoskillit/fleet/_api.py Outdated
Comment thread src/autoskillit/fleet/state_types.py Outdated
Comment thread src/autoskillit/fleet/state_types.py Outdated
Comment thread src/autoskillit/server/tools/tools_kitchen.py Outdated
Comment thread tests/arch/test_kitchen_id_assignment.py Outdated
Comment thread tests/arch/test_subpackage_isolation.py Outdated
Comment thread tests/arch/test_subpackage_isolation.py
Comment thread tests/cli/test_session_launch.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking issue detected. See the inline comments; the automated verdict is changes_requested. GitHub does not permit an author to request changes on their own PR, so this summary was submitted as COMMENT.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

This is a self-PR review. The following inline comments are advisory findings. 3 critical-severity issues (test hermeticity regressions) and 19 warnings must be addressed before merge. 12 info-severity findings are suggestions.

Comment thread src/autoskillit/cli/_prompts.py
Comment thread src/autoskillit/cli/_prompts.py Outdated
Comment thread src/autoskillit/execution/backends/codex.py
Comment thread src/autoskillit/fleet/_api.py
Comment thread src/autoskillit/fleet/_api.py
Comment thread tests/execution/backends/test_claude_startup_readiness.py
Comment thread tests/execution/backends/test_cli_conformance_probes.py
Comment thread tests/pipeline/test_kitchen_transition.py
Comment thread tests/server/test_dispatch_provenance_boundary.py
Comment thread tests/server/test_open_kitchen_transition.py
Trecek added 25 commits July 30, 2026 22:09
Trecek added 24 commits July 30, 2026 22:12
@Trecek
Trecek force-pushed the impl-rectify_mcp_startup_readiness_and_retry_immunity_2026-07-29_134135-20260729-164551 branch from a165215 to 2c52b2b Compare July 31, 2026 05:18
@Trecek
Trecek added this pull request to the merge queue Jul 31, 2026
Merged via the queue into develop with commit 40e1b5d Jul 31, 2026
4 of 5 checks passed
@Trecek
Trecek deleted the impl-rectify_mcp_startup_readiness_and_retry_immunity_2026-07-29_134135-20260729-164551 branch July 31, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant