Skip to content

Rectify: Shell-Capture Snapshot Authority - #4418

Merged
Trecek merged 34 commits into
developfrom
impl-rectify-shell-capture-snapshot-authority-20260729-095033
Jul 30, 2026
Merged

Rectify: Shell-Capture Snapshot Authority#4418
Trecek merged 34 commits into
developfrom
impl-rectify-shell-capture-snapshot-authority-20260729-095033

Conversation

@Trecek

@Trecek Trecek commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Makes a descriptor-verified, factory-only snapshot the sole authority for a FINAL shell capture.
  • Separates capture, snapshot, reference, delivery, and retention state, with every transition routed through one locked, revision-checked lifecycle core.
  • Makes reference publication and stdout delivery transactional while retaining the producer lease through delivery.
  • Hardens framed-ledger migration, restart reconciliation, descriptor rebinding defenses, and cleanup/reader handoff.
  • Adds the planned fault, race, migration, import-order, durability, integration, architecture, and documentation coverage.

Closes #4322

Validation

  • task test-check — PASS (34,009 passed, 630 skipped, 27 xfailed)
  • pre-commit run --all-files — PASS
  • Exact-commit implementation audit — GO (22/22 requirements covered; no missing, odd, or conflicting findings)
  • Dry-walkthrough — verified against the rectification plan

Implementation

The work is organized as the four planned implementation packages—verified snapshot
authority, reader leases, transactional delivery, and documentation/integration
ratchets—followed by one audit-remediation commit that closes every finding from the
first audit pass.

🤖 Generated with Claude Code via AutoSkillit

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/hooks/_capture_lifecycle.py Outdated
Comment thread src/autoskillit/hooks/_capture/_delivery.py
Comment thread src/autoskillit/hooks/_capture_artifacts.py
Comment thread src/autoskillit/hooks/_capture/_delivery.py Outdated
Comment thread src/autoskillit/hooks/_capture/_delivery.py Outdated
Comment thread src/autoskillit/hooks/_capture_contract.py
Comment thread src/autoskillit/hooks/_capture/_ledger.py
Comment thread tests/hooks/test_capture_lifecycle.py Outdated
Comment thread tests/hooks/test_capture_verified_reader.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See inline comments; reconciliation must not treat readable-but-unsynced ledger frames as durable authority.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested (self-authored PR; GitHub does not permit REQUEST_CHANGES)

Comment thread src/autoskillit/hooks/_capture/_sweep.py Outdated
Comment thread src/autoskillit/hooks/_capture/_delivery.py Outdated
Comment thread src/autoskillit/hooks/_capture/_snapshot.py
Comment thread src/autoskillit/hooks/_capture/_reader.py Outdated
Comment thread src/autoskillit/hooks/_capture/_resolver.py Outdated
Comment thread src/autoskillit/hooks/_capture/_snapshot.py Outdated
Comment thread src/autoskillit/hooks/_capture/_resolver.py
Comment thread src/autoskillit/hooks/_capture_artifacts.py Outdated
Comment thread src/autoskillit/hooks/_capture/_replay.py
Comment thread src/autoskillit/hooks/_capture/_snapshot.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See inline comments; changes are requested. GitHub does not permit REQUEST_CHANGES on a self-authored PR.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread src/autoskillit/hooks/_capture/_delivery.py
Comment thread src/autoskillit/hooks/_capture_lifecycle.py Outdated
Comment thread src/autoskillit/hooks/_capture_artifacts.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.

@Trecek
Trecek enabled auto-merge July 30, 2026 06:15
@Trecek
Trecek added this pull request to the merge queue Jul 30, 2026
Merged via the queue into develop with commit 423dd7c Jul 30, 2026
3 checks passed
@Trecek
Trecek deleted the impl-rectify-shell-capture-snapshot-authority-20260729-095033 branch July 30, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant