Rectify: Codex Shell-Capture Cleanup Lifecycle - #4405
Merged
Trecek merged 51 commits intoJul 29, 2026
Merged
Conversation
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review: blocking issues detected. See inline comments; changes are required. GitHub does not allow the PR author to submit a REQUEST_CHANGES review, so this verdict is recorded as a comment.
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
This was referenced Jul 28, 2026
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review: blocking findings detected. See inline comments — verdict: changes_requested. GitHub does not allow the PR author to submit a REQUEST_CHANGES event on their own pull request.
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
commented
Jul 28, 2026
Trecek
left a comment
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 28, 2026
Trecek
added a commit
that referenced
this pull request
Jul 29, 2026
## Summary - Restore branch-targeted CI runner and test-filter policy through one fail-closed event resolver. - Give develop-targeted pull requests and merge groups the immutable event base SHA for conservative filtering. - Remove PR #4405's redundant lifecycle-exception import suppression and add behavioral, manifest, and documentation ratchets. ## Target policy | Target | Runners | Filter | |---|---|---| | `develop` | `ubuntu-latest` | `conservative` | | `main` | `ubuntu-latest` | `none` | | `stable` | `ubuntu-latest`, `macos-15` | `none` | ## Stacked PR This correction is based on and targets PR #4405's head branch: `impl-rectify_codex_shell_capture_cleanup_lifecycle_2026-07-27_233858-20260728-080540`. ## Verification - Focused CI, manifest, hook, and Pyright suppression gate passed. - `task test-check`: 33,799 passed. - `pre-commit run --all-files` passed. - Hook registry hash and `.autoskillit/test-source-map.json` remained unchanged.
- Restore branch-targeted CI runner and test-filter policy through one fail-closed event resolver. - Give develop-targeted pull requests and merge groups the immutable event base SHA for conservative filtering. - Remove PR #4405's redundant lifecycle-exception import suppression and add behavioral, manifest, and documentation ratchets. | Target | Runners | Filter | |---|---|---| | `develop` | `ubuntu-latest` | `conservative` | | `main` | `ubuntu-latest` | `none` | | `stable` | `ubuntu-latest`, `macos-15` | `none` | This correction is based on and targets PR #4405's head branch: `impl-rectify_codex_shell_capture_cleanup_lifecycle_2026-07-27_233858-20260728-080540`. - Focused CI, manifest, hook, and Pyright suppression gate passed. - `task test-check`: 33,799 passed. - `pre-commit run --all-files` passed. - Hook registry hash and `.autoskillit/test-source-map.json` remained unchanged.
Trecek
force-pushed
the
impl-rectify_codex_shell_capture_cleanup_lifecycle_2026-07-27_233858-20260728-080540
branch
from
July 29, 2026 03:43
6c83344 to
533e1a0
Compare
Trecek
deleted the
impl-rectify_codex_shell_capture_cleanup_lifecycle_2026-07-27_233858-20260728-080540
branch
July 29, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a durable lifecycle owner for Codex shell-capture artifacts, including writer liveness, crash recovery, bounded reclamation, quarantine deletion, runner-tail cleanup, and a cleanup-only SessionStart hook.
Verification
Closes #4320
Closes #4321