Skip to content

Rectify: Issue #4382 — Live Plugin Artifact Lifetime - #4396

Merged
Trecek merged 101 commits into
developfrom
impl-rectify-issue-4382-plugin-artifact-lifetime-20260727-070744
Jul 28, 2026
Merged

Rectify: Issue #4382 — Live Plugin Artifact Lifetime#4396
Trecek merged 101 commits into
developfrom
impl-rectify-issue-4382-plugin-artifact-lifetime-20260727-070744

Conversation

@Trecek

@Trecek Trecek commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

AutoSkillit treated a projected plugin as a reusable pathname without representing the consuming process's ownership in the type system or cleanup protocol. This change introduces exact artifact identities, inherited shared leases for every physical child launch, exclusive identity-validated mutation, record-owned retirement policy, and static ratchets that prevent raw plugin paths and destructive bypasses from re-entering the architecture.

Closes #4382

Implementation Plan

Plan file: /home/talon/projects/generic_automation_mcp/.autoskillit/temp/rectify/rectify_issue_4382_plugin_artifact_lifetime_2026-07-27_070744.md

🤖 Generated with Claude Code via AutoSkillit

Trecek
Trecek commented Jul 27, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested (self-authored PR; posted as comment)

Comment thread src/autoskillit/cli/_marketplace.py Outdated
Comment thread src/autoskillit/cli/_plugin_artifact.py Outdated
Comment thread src/autoskillit/cli/session/_session_cook.py Outdated
Comment thread src/autoskillit/core/_plugin_cache.py Outdated
Comment thread src/autoskillit/core/types/_type_plugin_source.py
Comment thread tests/cli/test_install.py
Comment thread tests/cli/test_install_transaction.py
Comment thread tests/execution/headless/test_headless_recovery.py
Comment thread tests/infra/test_ci_dev_config.py Outdated
Comment thread tests/infra/test_plugin_source_ratchets.py Outdated
Trecek
Trecek commented Jul 27, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: changes requested. One blocking correctness issue and 13 warning findings were found; see the inline comments. GitHub does not allow the PR author to submit REQUEST_CHANGES on their own PR, so this verdict is recorded as a comment review.

Trecek
Trecek commented Jul 28, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested (submitted as COMMENT because GitHub does not allow authors to request changes on their own PR)

Comment thread tests/arch/test_execution_source_split.py Outdated
Comment thread tests/arch/test_subpackage_isolation.py Outdated
Comment thread tests/cli/test_install_transaction.py Outdated
Comment thread tests/cli/test_plugin_cache.py
Comment thread tests/infra/test_plugin_source_ratchets.py Outdated
Comment thread src/autoskillit/cli/_marketplace.py Outdated
Comment thread src/autoskillit/cli/_plugin_artifact.py Outdated
Comment thread src/autoskillit/workspace/_projection_cache.py Outdated
Comment thread src/autoskillit/workspace/skill_projection.py Outdated
Comment thread src/autoskillit/cli/_plugin_artifact.py
Trecek
Trecek commented Jul 28, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. Three critical artifact-lifecycle defects require changes; see the 22 inline comments for exact locations and remediation guidance.

Trecek
Trecek commented Jul 28, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/execution/recording.py
Comment thread tests/core/test_logging.py
Comment thread tests/cli/test_plugin_cache.py
Comment thread src/autoskillit/workspace/_install_state.py
Comment thread src/autoskillit/core/types/_type_plugin_source.py Outdated
Comment thread src/autoskillit/core/logging.py Outdated
Comment thread src/autoskillit/cli/_plugin_artifact.py Outdated
Comment thread src/autoskillit/workspace/skill_projection.py Outdated
Comment thread src/autoskillit/workspace/_projection_cache.py Outdated
Trecek
Trecek commented Jul 28, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See inline comments; changes are required. GitHub does not allow the PR author to submit REQUEST_CHANGES, so this verdict is recorded as a comment review.

@Trecek
Trecek force-pushed the impl-rectify-issue-4382-plugin-artifact-lifetime-20260727-070744 branch from 18585ba to fbe728d Compare July 28, 2026 13:59
Trecek added 23 commits July 28, 2026 07:24
@Trecek
feat: add plugin artifact lease contracts
fb2f491
@Trecek
feat: wire plugin artifact launch lifetime
0bfb9e4
@Trecek
feat: add identity-bound plugin retirement
a622fd3
@Trecek
feat: ratchet plugin artifact lifecycle
8a963f0
@Trecek
test: align plugin lifetime fleet contracts
21d2a0a
@Trecek
fix(review): keep install rollback under artifact lease
adea4e9
@Trecek
fix(review): preserve artifact control-flow exceptions
a017303
@Trecek
fix(review): preserve inherited descriptors for full launch lifetime
1f4902c
@Trecek
fix(review): validate retirement cache JSON types
a7e3ebc
@Trecek
fix(review): bind launch paths to leased identities
6f83b0d
@Trecek
fix(review): unify projected artifact identity contracts
1dc9469
@Trecek
fix(review): restrict projected artifact load modes
eb6152e
@Trecek
test(review): cover due retirement owner dispatch
fcd3c52
@Trecek
test(review): pin the exact CI operating-system matrix
939fa74
@Trecek
test(review): discover plugin lifecycle ratchet sites
cd2b1fe
@Trecek
fix(review): centralize artifact retirement ownership
32b28ac
@Trecek
fix(review): keep projection contracts within package bounds
f786a41
@Trecek
test(review): assert rollback target lease ownership
c4bb105
@Trecek
test(review): model binding descriptors across reloads
98b89d2
@Trecek
fix(review): normalize plugin gateway stub ordering
f29923e
@Trecek
test(review): enforce plugin authority protocol typing
605a346
@Trecek
fix(review): reject malformed retirement cache records
9d8f64c
@Trecek
test(review): assert cook binding survives child reap
4770dbf
Trecek
Trecek commented Jul 28, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/cli/_marketplace.py Outdated
Comment thread src/autoskillit/cli/_marketplace.py Outdated
Comment thread src/autoskillit/cli/_marketplace.py Outdated
Comment thread src/autoskillit/cli/_plugin_artifact.py Outdated
Comment thread src/autoskillit/core/_plugin_cache.py
Comment thread src/autoskillit/workspace/_projected_artifact/materialization.py
Comment thread tests/cli/test_plugin_source_authority.py
Comment thread tests/contracts/test_plugin_artifact_lifetime.py
Comment thread tests/infra/test_plugin_source_ratchets.py Outdated
Comment thread tests/server/test_server_init_gate.py Outdated
Trecek
Trecek commented Jul 28, 2026
View reviewed changes

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See the 19 inline comments; resolve the critical lease-contention rollback issue and warning findings before merge. GitHub cannot record REQUEST_CHANGES from the PR author, so this verdict is submitted as COMMENT.

Trecek added 22 commits July 28, 2026 14:51
@Trecek
fix(review): require integer retirement schema versions
a39f929
@Trecek
refactor(review): centralize projected lease cleanup
86d18cc
@Trecek
fix(review): validate projection versions at boundaries
37dc0ee
@Trecek
fix(review): preserve installed lease errors during cleanup
8c02697
@Trecek
fix(review): preserve cache retirement errors on close
5b3fd4c
@Trecek
fix(review): acquire install lease before mutations
4d05e0c
@Trecek
fix(review): derive retirement roots from owners
d750c66
@Trecek
fix(review): migrate legacy retirements before install
0aba865
@Trecek
fix(review): reject duplicate retirement record ids
32cafc0
@Trecek
fix(review): defer reclaim on unsafe cache reread
73f8d06
@Trecek
fix(review): retain retirement authority on artifact io
2fb787a
@Trecek
fix(review): bind inherited fds to lease ownership
631a2dd
@Trecek
test(review): guard transient projection io from repair
de1275c
@Trecek
fix(review): report unreadable retirement identity
86b94ef
@Trecek
test(review): prove writer leases are released
2528cf6
@Trecek
test(review): prove failed binding releases reader
e8f176d
@Trecek
test(review): verify mismatch kitchen activation
11818db
@Trecek
test(review): cover lifecycle mutation scan triggers
3b55f16
@Trecek
fix(review): preserve manifest io authority
540e8a2
@Trecek
fix(review): preserve projected unavailable errors
af7f735
@Trecek
test(review): exercise mismatch notification path
e291d94
@Trecek
test(review): register artifact identity split
cd11ecf
@Trecek
Trecek added this pull request to the merge queue Jul 28, 2026
Merged via the queue into develop with commit d7727e0 Jul 28, 2026
5 checks passed
@Trecek
Trecek deleted the impl-rectify-issue-4382-plugin-artifact-lifetime-20260727-070744 branch July 28, 2026 22:57
This was referenced Aug 4, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Trecek