Skip to content

minor refactor: cleanup parameters of open_library and open_sqlite_library#1294

Merged
CyanVoxel merged 1 commit into
TagStudioDev:mainfrom
Computerdores:refactor/–open_library
May 9, 2026

Hidden character warning

The head ref may contain hidden characters: "refactor/\u0096open_library"
Merged

minor refactor: cleanup parameters of open_library and open_sqlite_library#1294
CyanVoxel merged 1 commit into
TagStudioDev:mainfrom
Computerdores:refactor/–open_library

Conversation

@Computerdores
Copy link
Copy Markdown
Collaborator

@Computerdores Computerdores commented Jan 18, 2026

Summary

A minor refactor of the Library.open_library method and the parameters of the Library.open_sqlite_library method.
No functional changes were made; a pure refactor.

Note: Ignore the invisible unicode char in the head ref; windows was doing windows things.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Jan 18, 2026
@Computerdores Computerdores added Type: Refactor Code that needs to be restructured or cleaned up TagStudio: Library Relating to the TagStudio library system labels Jan 18, 2026
@Computerdores Computerdores mentioned this pull request Jan 18, 2026
8 tasks
@Computerdores Computerdores added the Status: Review Needed A review of this is needed label Jan 22, 2026
Copy link
Copy Markdown
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this!

@CyanVoxel CyanVoxel merged commit 910d2b7 into TagStudioDev:main May 9, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from 🏓 Ready for Review to ✅ Done in TagStudio Development May 9, 2026
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label May 9, 2026
@CyanVoxel CyanVoxel added this to the Alpha v9.6.0 milestone May 9, 2026
@Computerdores Computerdores deleted the refactor/–open_library branch May 12, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TagStudio: Library Relating to the TagStudio library system Type: Refactor Code that needs to be restructured or cleaned up

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants