Skip to content

Fixes and improvements#534

Merged
KenVanHoeylandt merged 6 commits into
mainfrom
develop
Jun 19, 2026
Merged

Fixes and improvements#534
KenVanHoeylandt merged 6 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Fixed Grove I2C port pin mappings for M5Stack Cardputer, Core2, CoreS3, and StackChan devices to ensure proper hardware compatibility.
  • Documentation

    • Updated GPS device references and setup instructions for improved clarity.
    • Refreshed project roadmap with updated feature priorities and feature ideas.
  • Chores

    • Enhanced build system to automatically clean stale build directories when switching device platforms.

@KenVanHoeylandt KenVanHoeylandt changed the title Various improvements Fixes and improvements Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request renames the Grove port GPIO pin properties pinSdaRx/pinSclTx to pinSdaTx/pinSclRx across the ESP32 binding schema, the Esp32GroveConfig C++ struct, the start_child driver function (correcting UART and I2C pin routing), and five M5Stack device trees (cardputer, cardputer-adv, core2, cores3, stackchan). Additionally, device.py gains two helper functions and updated main() logic to detect a prior IDF target from sdkconfig and delete stale build directories when the target changes. Documentation in gps.md and ideas.md is updated with revised device entries and reprioritized bullet lists, and Tactility.cpp swaps a root.h include for InitEsp.h within the ESP platform block.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Various improvements' is vague and generic, failing to describe any specific change in the changeset which includes GPIO pin mapping updates, documentation revisions, build cleanup logic, and device tree modifications. Replace with a specific title reflecting the main change, such as 'Swap Grove I2C SDA/SCL pin roles across device tree configs and drivers' or 'Fix Grove port pin assignments and add SD card build cleanup logic'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 63688e83-2293-4f78-8b01-60bf25da4ca8

📥 Commits

Reviewing files that changed from the base of the PR and between a35c88c and 4f6f61f.

📒 Files selected for processing (12)
  • Devices/m5stack-cardputer-adv/m5stack,cardputer-adv.dts
  • Devices/m5stack-cardputer/m5stack,cardputer.dts
  • Devices/m5stack-core2/m5stack,core2.dts
  • Devices/m5stack-cores3/m5stack,cores3.dts
  • Devices/m5stack-stackchan/m5stack,stackchan.dts
  • Documentation/gps.md
  • Documentation/ideas.md
  • Platforms/platform-esp32/bindings/espressif,esp32-grove.yaml
  • Platforms/platform-esp32/include/tactility/drivers/esp32_grove.h
  • Platforms/platform-esp32/source/drivers/esp32_grove.cpp
  • Tactility/Source/Tactility.cpp
  • device.py
💤 Files with no reviewable changes (1)
  • Tactility/Source/Tactility.cpp

Comment thread device.py
@KenVanHoeylandt KenVanHoeylandt merged commit e8b9a1f into main Jun 19, 2026
58 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the develop branch June 19, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant