fix(postgres): use rustls connector in test_connection to support client certs and custom CA - #678
Open
adisusilayasa wants to merge 1 commit into
Open
Conversation
…ent certs and custom CA
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by glm-5.2 · Input: 29.9K · Output: 5.4K · Cached: 295.9K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
PostgresDriverdid not implementtest_connection(), falling back to the defaultDatabaseDriver::test_connection()implementation which constructed a connection URL and connected viasqlx::AnyConnection.This caused connection tests to fail for PostgreSQL databases requiring:
ssl_cert/ssl_key) — becausesqlxconnection string did not include client certificates, causing servers to reject withFATAL: connection requires a valid client certificate.ssl_ca) — becausesqlxon macOS uses the system keychain rather than honoring the user-supplied CA bundle intest_connection.Changes
test_connection()onPostgresDriverto usetokio-postgres-rustls(build_postgres_configurationsandbuild_postgres_tls_connector), ensuring the test connection path matches the query pool path and properly honorsssl_ca,ssl_cert, andssl_key.