fix(datagrid): show column comments in headers#1842
Merged
datlechin merged 5 commits intoJul 10, 2026
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
…comments # Conflicts: # CHANGELOG.md
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data grid columns with database comments now show those comments directly in the column header when object comments are enabled, so users do not have to hover each header to discover the extra context. Headers expand to a two-line layout only when a visible column has a comment, and return to the compact height when comments are disabled or the commented column is hidden.
This also renames the command-output password resolver test file/type to avoid the duplicate Swift test filename that currently prevents the test target from compiling on fresh branches from
main.Fixes #1789
Validation
swiftlint --strict TablePro/Views/Results/DataGridColumnPool.swift TablePro/Views/Results/SortableHeaderCell.swift TableProTests/Views/Results/DataGridColumnPoolTests.swift TableProTests/Views/Results/SortableHeaderCellTests.swift TableProTests/Core/Utilities/Connection/PasswordSourceResolverCommandOutputTests.swiftxcodebuild -project TablePro.xcodeproj -scheme TablePro -destination 'platform=macOS' -skipPackagePluginValidation -only-testing:TableProTests/SortableHeaderCellTests -only-testing:TableProTests/DataGridColumnPoolTests -only-testing:TableProTests/PasswordSourceResolverCommandOutputTests CODE_SIGNING_ALLOWED=NO test