fix(datagrid): cell/selection copy, persist hidden columns & filters, JSON popover#1459
Conversation
# Conflicts: # .gitignore # CHANGELOG.md # CLAUDE.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c191cc3a52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let clickedColumnIndex = sender.representedObject as? NSNumber { | ||
| return clickedColumnIndex.intValue | ||
| } |
There was a problem hiding this comment.
Preserve row-copy fallback from row-number menu
When the context menu is opened from the row-number/non-data column on the currently focused row, representedObject is nil, so this fallback reuses the focused data column and Copy copies that cell instead of the full row. This breaks the advertised row-header fallback path; the focused-cell fallback needs to be gated so a click that resolved to a non-data column still dispatches row copy.
Useful? React with 👍 / 👎.
…erState from forcing panel visibility
…d fix column-visibility expectations
…filter-bar default
|
Pushed review fixes (commits
Build and Note: this branch is behind |
Summary
SELECT *.Test plan
0x…, NULL →NULL)