fix(plugin-oracle): log connection target string instead of service enum#1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OracleConnection.connect()interpolated the OracleNIOOracleServiceMethodenum into an OSLog debug line. That type conforms to none of OSLog's supported interpolation types, so the build failed with:Fix
Log the connection identifier string instead of the enum, using Oracle's Easy Connect separators so the line stays accurate for both modes the SID option (#1431) introduced:
host:port/servicehost:port:sidNo retroactive
CustomStringConvertibleconformance on the third-party type, and the identifier is what's actually useful when debugging a connection.Notes
Follow-up to #1431 (still unreleased), so no CHANGELOG entry per the unreleased-fix rule.