fix: harden example checks and close review findings across eight examples#56
Merged
Conversation
…mples
A full review pass over the sixteen examples found the oldest four predate
the bmesh-gear anatomy and carried real debt; this closes everything
actionable:
- depsgraph-export: replace the shipped scratch docstring ("Candidate B ...
(SCRATCH)") with the standard anatomy, and add the missing --output render
path (base cube beside its evaluated form, resting the subsurf ball on the
floor via its own evaluated bounds) so the gallery assets now come from the
shipped script; OBJ path moves to --obj.
- swatch-grid: add the check-only default mode CI conventions promise
(--output was required), and make the EEVEE engine-id assertion real.
- swatch-grid / turntable / gn-sdf-remesh: the old engine-id check compared
a value to itself and could never fire; it now witnesses the inversion by
asserting the WRONG era's id is rejected (TypeError) and the helper's id
accepted - live-verified on 4.5.11 and 5.1.2.
- wave-displace: the vertex-count guard was unreachable (foreach_set cannot
resize); replaced with a strictly stronger every-vertex closed-form check
that a stride/interleave bug cannot hide from.
- damped-track-aim: delete the inert legacy EEVEE bloom block (use_bloom
exists on neither supported version and contradicted compositor-glare),
fix the orphaned wall mesh copy, and correct the cos(3.6deg) comment.
- driver-wave: remove the unreachable else branch in the driver function.
- Backport the always-free-bmesh try/finally and the taa_render_samples shim
to the early examples that lacked them; sync READMEs, gallery.json, the
smoke workflow comment, and regenerate docs/gallery.
All six touched checks pass check-only on Blender 4.5.11 LTS and 5.1.2;
swatch-grid's CI render invocation and the new depsgraph-export render were
run and visually inspected on both.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full review pass over all sixteen examples (four parallel deep-read reviews, findings hand-verified) surfaced one shipped defect and several systematic weaknesses concentrated in the four oldest examples. This PR closes everything actionable.
Fixes
"""Candidate B: ... (SCRATCH)) replaced with standard anatomy; missing--outputrender path added (base cube beside its evaluated form, floor contact via its own evaluated bounds) so the gallery assets now come from the shipped script; OBJ path moved to--obj--outputwasrequired=True); engine-id check made realTypeError) and the helper''s id acceptedforeach_setcannot resize); replaced with a strictly stronger every-vertex closed-form check;arrayidiom clarifieduse_bloomexists on neither supported version and contradicted compositor-glare); orphaned wall mesh copy fixed; angle comment correctedelsebranch removed from the driver functionalways-free-bmeshtry/finally and thetaa_render_samplesshim backportedREADMEs, gallery.json, and the smoke-workflow comment synced;
docs/gallery/regenerated (detail pages embed highlighted source, hence the page churn).Test plan
--engine cycles --samples 8 --width 640) passes on both buildspython scripts/build_gallery.pyre-run;py_compileclean on all touched scripts🤖 Generated with Claude Code