Allow request headers to be specified#5
Merged
MattiasBuelens merged 2 commits intoTHEOplayer:mainfrom Mar 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CDN I'm working against checks the
Refererheader, and rejects requests for the manifest without the right value.This change lets the user specify one or more
--header/-Hflags to therecordcommand. I aimed for the same format as Curl for specifying the header name and value. A clap value_parser ensures the header name and value are valid. The headers are used for all requests.Kinda shoved the header map into the RecordOptions, hope that looks OK to you
And thanks for all your recent improvements!