map headers from master manifest request to master manifest load#123
Open
therama wants to merge 4 commits into
Open
map headers from master manifest request to master manifest load#123therama wants to merge 4 commits into
therama wants to merge 4 commits into
Conversation
ceyhun-o
requested changes
May 12, 2026
Contributor
ceyhun-o
left a comment
ceyhun-o
left a comment
There was a problem hiding this comment.
Let's figure out all the remaining issues we discussed on Slack.
Please also add a changelog entry.
ceyhun-o
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the sideloaded subtitles connector we fetch the master manifest to edit it. Previously, the fetch request was made via a default request which was missing all the headers that were configured from the original player manifest request. In this PR, we make sure to map those headers, including the user agent value, in order to avoid unexpected behavior/response from the server.