Conversation
- Added value converter so 'nonunique' keyword has the value "false" for setting isUnique. - Also updated KerMLOutlineTreeProvider to show "ordered" and "nonunique" in outline entry for a feature.
- Removed Feature_isNonunique_SettingDelegate. - Updated CustomUML2EcoreImporter to not add isNonunique.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises the Xtext grammars for KerML and SysML so that it is no longer to add the property
Feature::isNonuniqueto the Ecore metamodel.Background
The default for the
Feature::isUniqueproperty istrue. In the textual notation, thenonuniquekeyword is used to set this property tofalse. However, the Xtext grammar?=notation only supports setting a property totrueon the parsing of a specific keyword.The previous workaround for this was for the
CustomUML2EcoreConvertertoadd anisNonuniqueproperty toFeaturewhen generating the Ecore metamodel. The setting of this property was implemented to setisUniqueto the opposite value. This allowedisNonunique ?= 'nonunique'to be used in the Xtext grammar.Changes
isNonunique ?= 'nonunique'toisUnique = Nonunique.org.omg.kerml.xtext.conversion, with the Xtend classes:KerMLValueConverterService– This is bound as theIValueConverterServiceinKerMLRuntimeModule.NonuniqueValueConverter– This is the single provided value converter. It converts the value"nonunique"tofalse.isNonuniqueproperty.org.omg.sysml.importer.CustomUML2EcoreImporterto not addisNonuniquetoFeature.Feature_isNonunique_SettingDelegate.SysML.ecoreandorg.omg.sysml.lang.sysml.Feature.