Allow the user to specify a non-default classloader for the annotation frame factory#42
Open
jsight wants to merge 1 commit intoSyncleus:masterfrom
Open
Allow the user to specify a non-default classloader for the annotation frame factory#42jsight wants to merge 1 commit intoSyncleus:masterfrom
jsight wants to merge 1 commit intoSyncleus:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
============================================
- Coverage 84.86% 84.77% -0.09%
- Complexity 452 453 +1
============================================
Files 31 31
Lines 1407 1412 +5
Branches 283 283
============================================
+ Hits 1194 1197 +3
- Misses 70 72 +2
Partials 143 143
Continue to review full report at Codecov.
|
Member
|
@jsight Hey, things calmed down here and im going through your PR. Can you stop by gitter so we can chat about your use case before I make a decision on merging? |
Contributor
Author
|
I will do that as soon as possible.
…On Tue, Jan 16, 2018 at 6:39 PM, Jeffrey Phillips Freeman < ***@***.***> wrote:
@jsight <https://github.com/jsight> Hey, things calmed down here and im
going through your PR. Can you stop by gitter so we can chat about your use
case before I make a decision on merging?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABIHbR3PtcckEMRTYCGfV9pmQthmUn8Yks5tLTM6gaJpZM4RWw1Y>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really still not sufficient for our use case, as we also rely on the typemanager being able to return multiple interface classes.
I wonder if that is something that we could integrate into upstream later on? Perhaps we can talk about it more?