Skip to content

Pr 377 phpstan fix #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rust-le wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Pr 377 phpstan fix #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0554411
Allow compatibility with symfony/ux-live-component and symfony/ux-twi…
tomkalon Aug 10, 2026
1a80c58
Set default component directory for Twig components
tomkalon Aug 11, 2026
41f0af8
Fix upgrade phpstan/phpstan to ^2.1 to fix PHP 8.4 / Symfony 8 CI fai…
rust-le Aug 12, 2026
5555e0b
Fix sync monorepo-builder.php phpstan versions with composer.json
rust-le Aug 12, 2026
cff1d1f
Fix configure twig_component in AdminUi, BootstrapAdminUi and TwigExt…
rust-le Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,17 @@
"symfony/twig-bundle": "^6.4 || ^7.4 || ^8.0",
"symfony/ux-autocomplete": "^2.17",
"symfony/ux-icons": "^2.20",
"symfony/ux-live-component": "^2.17",
"symfony/ux-twig-component": "^2.17",
"symfony/ux-live-component": "^2.17 || ^3.0",
"symfony/ux-twig-component": "^2.17 || ^3.0",
"twig/twig": "^2.15 || ^3.0",
"webmozart/assert": "^1.9"
},
"require-dev": {
"doctrine/doctrine-fixtures-bundle": "^4.3",
"matthiasnoback/symfony-config-test": "^6.1",
"matthiasnoback/symfony-dependency-injection-test": "^6.1.0",
"phpstan/phpstan": "^1.10",
"phpstan/phpstan-symfony": "^1.3",
"phpstan/phpstan": "^2.1",
"phpstan/phpstan-symfony": "^2.0",
"phpunit/phpunit": "^10.5",
"sylius-labs/coding-standard": "^4.0",
"symfony/browser-kit": "^6.4 || ^7.4 || ^8.0",
Expand Down
2 changes: 2 additions & 0 deletions config/packages/twig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ twig:

twig_component:
anonymous_template_directory: 'components/'
defaults:
App\Twig\Component\: 'components/'

when@test:
twig:
Expand Down
4 changes: 2 additions & 2 deletions monorepo-builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
ComposerJsonSection::REQUIRE => [
],
ComposerJsonSection::REQUIRE_DEV => [
'phpstan/phpstan' => '^1.10',
'phpstan/phpstan-symfony' => '^1.3',
'phpstan/phpstan' => '^2.1',
'phpstan/phpstan-symfony' => '^2.0',
'symfony/debug-bundle' => '^6.4 || ^7.4 || ^8.0',
'symfony/flex' => '^2.4',
'symplify/monorepo-builder' => '11.2.*',
Expand Down
53 changes: 46 additions & 7 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,55 @@
parameters:
ignoreErrors:
-
message: "#^Call to method arrayNode\\(\\) on an unknown class Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeBuilder\\<Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\ArrayNodeDefinition\\>\\.$#"
message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: src/TwigExtra/src/Symfony/DependencyInjection/Configuration.php
path: src/TwigHooks/src/Bag/DataBag.php

-
message: "#^Call to method arrayNode\\(\\) on an unknown class Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeBuilder\\<Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\ArrayNodeDefinition\\>\\.$#"
count: 2
path: src/TwigHooks/src/DependencyInjection/Configuration.php
message: '#^Parameter \#1 \$values of method Symfony\\Component\\Console\\Completion\\CompletionSuggestions\:\:suggestValues\(\) expects list\<string\|Symfony\\Component\\Console\\Completion\\Suggestion\>, array\<string\> given\.$#'
identifier: argument.type
count: 1
path: src/TwigHooks/src/Console/Command/DebugTwigHooksCommand.php

-
message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: src/TwigHooks/src/Hookable/Metadata/HookableMetadata.php

-
message: '#^Trait Sylius\\TwigHooks\\LiveComponent\\HookableLiveComponentTrait is used zero times and is not analysed\.$#'
identifier: trait.unused
count: 1
path: src/TwigHooks/src/LiveComponent/HookableLiveComponentTrait.php

-
message: '#^Method Sylius\\TwigHooks\\LiveComponent\\Hydration\\DataBagHydrationExtension\:\:hydrate\(\) never returns null so it can be removed from the return type\.$#'
identifier: return.unusedType
count: 1
path: src/TwigHooks/src/LiveComponent/Hydration/DataBagHydrationExtension.php

-
message: '#^Property Sylius\\TwigHooks\\Profiler\\HooksDataCollector\:\:\$profile on left side of \?\?\= is not nullable nor uninitialized\.$#'
identifier: nullCoalesce.initializedProperty
count: 1
path: src/TwigHooks/src/Profiler/HooksDataCollector.php

-
message: '#^Instanceof between Sylius\\TwigHooks\\Hookable\\AbstractHookable and Sylius\\TwigHooks\\Hookable\\AbstractHookable will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: src/TwigHooks/src/Registry/HookablesRegistry.php

-
message: "#^Call to method booleanNode\\(\\) on an unknown class Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeBuilder\\<Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\ArrayNodeDefinition\\>\\.$#"
message: '#^Trait Sylius\\TwigHooks\\Twig\\Component\\HookableComponentTrait is used zero times and is not analysed\.$#'
identifier: trait.unused
count: 1
path: src/TwigHooks/src/DependencyInjection/Configuration.php
path: src/TwigHooks/src/Twig/Component/HookableComponentTrait.php

-
message: '#^Call to function method_exists\(\) with Twig\\Parser and ''parseExpression'' will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 2
path: src/TwigHooks/src/Twig/TokenParser/HookTokenParser.php
4 changes: 4 additions & 0 deletions src/AdminUi/tests/Functional/.application/config/packages/twig_component.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
twig_component:
anonymous_template_directory: 'components/'
defaults:
App\Twig\Component\: 'components/'
2 changes: 1 addition & 1 deletion src/BootstrapAdminUi/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"symfony/stimulus-bundle": "^2.17",
"symfony/ux-autocomplete": "^2.17",
"symfony/ux-icons": "^2.20",
"symfony/ux-live-component": "^2.17"
"symfony/ux-live-component": "^2.17 || ^3.0"
},
"require-dev": {
"doctrine/doctrine-bundle": "^2.13 || ^3.0 || ^4.0",
Expand Down
4 changes: 4 additions & 0 deletions src/BootstrapAdminUi/tests/Functional/.application/config/packages/twig_component.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
twig_component:
anonymous_template_directory: 'components/'
defaults:
App\Twig\Component\: 'components/'
2 changes: 1 addition & 1 deletion src/TwigExtra/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"php": "^8.1",
"symfony/http-kernel": "^6.4 || ^7.4 || ^8.0",
"symfony/twig-bundle": "^6.4 || ^7.4 || ^8.0",
"symfony/ux-twig-component": "^2.17"
"symfony/ux-twig-component": "^2.17 || ^3.0"
},
"require-dev": {
"matthiasnoback/symfony-dependency-injection-test": "^6.1.0",
Expand Down
4 changes: 4 additions & 0 deletions src/TwigExtra/tests/Functional/.application/config/packages/twig_component.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
twig_component:
anonymous_template_directory: 'components/'
defaults:
App\Twig\Component\: 'components/'
4 changes: 2 additions & 2 deletions src/TwigHooks/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"symfony/expression-language": "^6.4 || ^7.4 || ^8.0",
"symfony/http-kernel": "^6.4 || ^7.4 || ^8.0",
"symfony/stopwatch": "^6.4 || ^7.4 || ^8.0",
"symfony/ux-live-component": "^2.17",
"symfony/ux-twig-component": "^2.17",
"symfony/ux-live-component": "^2.17 || ^3.0",
"symfony/ux-twig-component": "^2.17 || ^3.0",
"symfony/twig-bundle": "^6.4 || ^7.4 || ^8.0",
"twig/twig": "^2.15 || ^3.0",
"webmozart/assert": "^1.9"
Expand Down
Loading