Terminal frame color customization and optional glossiness#760
Open
forestbeasts wants to merge 4 commits intoSwordfish90:masterfrom
Open
Terminal frame color customization and optional glossiness#760forestbeasts wants to merge 4 commits intoSwordfish90:masterfrom
forestbeasts wants to merge 4 commits intoSwordfish90:masterfrom
Conversation
added 4 commits
October 2, 2021 12:01
I mean, it's how it works in the real world; it's added to the frame's base color, not occluded by the frame.
It's saved in the profile, and defaults to white.
Lets you turn off the bright reflections.
|
I checked out your repo hoping to get a solution for this, but it didn't worked for me: |
|
@diegodorado it works if you apply also this patch as well:
|
eric2801
added a commit
to eric2801/cool-retro-term
that referenced
this pull request
Aug 14, 2024
Swordfish90
force-pushed
the
master
branch
2 times, most recently
from
b65f478 to
8cf3031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For that shiny look!
This adds a profile setting to change the terminal frame color, and optional glossiness and a profile setting to control that. This simply adds the reflected terminal text to the frame color, as you would expect.
The frame color is set to #FFFFFF and the glossiness to 0 by default, so this shouldn't affect existing profiles. Though if you set the frame color/glossiness and then load an old profile without these settings stored in it, it won't touch them (while still changing all the stuff it has settings for).