feat: Profile identification#593
Open
Blaumaus wants to merge 2 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds visitor identification through public analytics endpoints, ClickHouse profile aliases, canonicalized analytics queries, JavaScript and Node tracker APIs, and documentation for identify/reset behavior. ChangesVisitor identity linking
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Visitor
participant Tracker
participant IdentifyAPI
participant AnalyticsService
participant AnalyticsStore
Visitor->>Tracker: identify(profileId)
Tracker->>IdentifyAPI: POST identify
IdentifyAPI->>AnalyticsService: validate request and resolve identities
AnalyticsService->>AnalyticsStore: link anonymous and identified profiles
IdentifyAPI-->>Tracker: return canonical profileId
Tracker-->>Visitor: use identified profile for tracking
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/apps/cloud/src/analytics/analytics.service.ts (1)
2466-2499: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winConsider negative caching for unlinked anon lookups.
getUserProfileForAnononly writes to Redis on a positive hit (Line 2494-2496). The overwhelmingly common case — an anonymous profile that was never identified — falls through to aprofile_aliasesClickHouse query on every call. This runs on hot read paths (getSessionDetails,resolveProfileIdentity), so a short-lived negative cache (e.g. a sentinel value with a small TTL) would remove a per-request CH round-trip.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/apps/cloud/src/analytics/analytics.service.ts` around lines 2466 - 2499, Update getUserProfileForAnon to cache unlinked lookups using a dedicated sentinel value with a short TTL, return null when that sentinel is read, and continue returning cached userProfileId values normally. Store the sentinel when ClickHouse finds no userProfileId while preserving the existing positive-cache behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/apps/cloud/src/analytics/analytics.controller.ts`:
- Around line 3308-3320: Add the same rate-limit and bot checks used by the
other public ingestion routes to the identify handlers in
backend/apps/cloud/src/analytics/analytics.controller.ts (lines 3308-3320) and
backend/apps/community/src/analytics/analytics.controller.ts (lines 2799-2811),
applying them before validation or the profile-linking flow in identify. Ensure
both public endpoints invoke checkRateLimit and checkBot consistently.
---
Nitpick comments:
In `@backend/apps/cloud/src/analytics/analytics.service.ts`:
- Around line 2466-2499: Update getUserProfileForAnon to cache unlinked lookups
using a dedicated sentinel value with a short TTL, return null when that
sentinel is read, and continue returning cached userProfileId values normally.
Store the sentinel when ClickHouse finds no userProfileId while preserving the
existing positive-cache behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c03edfbe-1647-4222-9c36-f7fe7ee91ce5
📒 Files selected for processing (17)
backend/apps/cloud/src/analytics/analytics.controller.tsbackend/apps/cloud/src/analytics/analytics.service.tsbackend/apps/cloud/src/analytics/dto/identify.dto.tsbackend/apps/community/src/analytics/analytics.controller.tsbackend/apps/community/src/analytics/analytics.service.tsbackend/apps/community/src/analytics/dto/identify.dto.tsbackend/migrations/clickhouse/2026_07_17_profile_aliases.jsbackend/migrations/clickhouse/initialise_database.jsdocs/content/docs/analytics-dashboard/profiles-and-sessions.mdxdocs/content/docs/api/events.mdxdocs/content/docs/script-reference.mdxdocs/content/docs/visitor-identification.mdxpackages/tracker-js/README.mdpackages/tracker-js/src/Lib.tspackages/tracker-js/src/index.tspackages/tracker-node/README.mdpackages/tracker-node/src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If applicable, please describe what changes were made in this pull request.
Community Edition support
Database migrations
Documentation
Summary by CodeRabbit