Fix Common Errors: tweak Step 2 button flow and add fixes-applied counter#11322
Merged
Merged
Conversation
…ounter Replace the misleading "Apply fixes & close" button with a "Done" button that commits already-applied fixes without triggering an additional apply pass. Add a "Fixes applied: X" label in the bottom-left that accumulates after each "Apply selected fixes" click and resets when re-entering Step 2.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Step 2 UX of the Fix Common Errors tool by clarifying the dialog’s “exit” action and surfacing how many fixes have been applied during the session.
Changes:
- Replaced the misleading “Apply fixes & close” action with a Step 2 Done button that closes and commits the current state without applying additional fixes.
- Added a Step 2 “Fixes applied: X” label driven by the existing
_totalFixesaccumulator andXFixesAppliedlanguage string. - Reset the fixes-applied counter/text when entering Step 2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ui/Features/Tools/FixCommonErrors/FixCommonErrorsWindow.cs | Renames the Step 2 close action to “Done” and adds a bottom-left “Fixes applied” label bound to the view model. |
| src/ui/Features/Tools/FixCommonErrors/FixCommonErrorsViewModel.cs | Adds FixesAppliedText, updates it after applying fixes, resets it when entering Step 2, and removes the implicit apply-on-OK behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Step 2 of the Fix Common Errors dialog had two UX issues:
Confusing and redundant buttons
The "Apply fixes & close" button was misleading in two ways: its name implied it would apply all fixes, when it actually only applied selected ones — the same as clicking "Apply selected fixes" and then closing. Having both buttons side by side created confusion about which one to use and what each one committed.
The adjacent "Cancel" button added to the confusion: it wasn't clear whether it would discard manually typed edits in the text box, or only the pending (unapplied) fixes in the grid.
No feedback on applied fixes
_totalFixeswas already being accumulated in the view model but was never surfaced in the UI, so users had no indication of how many fixes had been applied across multiple "Apply selected fixes" clicks.Changes
XFixesAppliedlanguage string and the existing_totalFixesaccumulator). The label appears after the first apply and resets when re-entering Step 2.buttonApplyFixeslocal variable tobuttonDoneto match its new purpose.