Fix "Save As" not appending format extension for language-coded filenames#10406
Open
ivandrofly wants to merge 1 commit intoSubtitleEdit:mainfrom
Open
Fix "Save As" not appending format extension for language-coded filenames#10406ivandrofly wants to merge 1 commit intoSubtitleEdit:mainfrom
ivandrofly wants to merge 1 commit intoSubtitleEdit:mainfrom
Conversation
…ded filenames When extracting subtitles from MKV with a two-letter language code like .sv, the save dialog received a filename without the format extension (e.g., .srt), causing Windows to treat the language code as the file extension. Closes SubtitleEdit#10349
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.svfor Swedish), the "Save As" dialog suggested a filename without the subtitle format extension (e.g.,.srt)name.svinstead ofname.sv.srtSaveSubtitleAs()DefaultExtensiontoFilePickerSaveOptionsinPickSaveSubtitleFileAs(), matching the existing behavior inPickSaveSubtitleFile()Test plan
.svand English.en).sv.srt(not just.sv).en.srt.srtfile, press "Save As" — verify the suggested filename still ends with.srt(no double extension)🤖 Generated with Claude Code