Modernize repo and make sure it works with ST4#9
Modernize repo and make sure it works with ST4#9Frizlab wants to merge 183 commits intoSublimeText:masterfrom
Conversation
AFAICT the tests **must** be run in Sublime Using <https://github.com/SublimeText/UnitTesting> probably helps (and it can also run the tests in GitHub Actions).
|
There are probably more tests we could do, but I declare the PR ready for review! \o/ |
|
Oh. I forgot the Readme 😅 |
michaelblyons
left a comment
michaelblyons
left a comment
There was a problem hiding this comment.
Looks like good work! I have a couple metadata comments and a little bike-shedding.
| class ModelineInstruction(ABC): | ||
|
|
||
| class ValueModifier(str, Enum): | ||
| NONE = "" |
There was a problem hiding this comment.
What do you think about SET instead of NONE here?
There was a problem hiding this comment.
I think NONE makes more sense because it’s a modifier. Ultimately the action will always be to set the value.
|
Done! Not sure it’s actually better to create the parser from the format |
|
Now waiting on sublimehq/package_control_channel#9333. |
4 participants
That being said:
I have no idea if it works before ST4 nowIt does not work before ST4;I have not succeeded in running the tests (UnitTesting shows a panel at the bottom, but it is desperately empty; I suspect a syntax error, or something of that nature, but I don’t know for sure and am not sure how to debug…)-> Fixed;I have removed the support for vim modelines. There is a dedicated plugin for that if needed; let’s not mix everything up!-> I actually enhanced the support for it, as well as added Emacs modelines;