Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/com/styra/opa/wasm/builtins/String.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ private static JsonNode sprintfImpl(OpaWasm instance, JsonNode operand0, JsonNod
if (format.contains("%v")) {
format = format.replaceAll("%v", "%s");
}
// %q wraps the string in double quotes (Go/Rego semantics)
if (format.contains("%q")) {
format = format.replace("%q", "\"%s\"");
}

var result = java.lang.String.format(format, args.toArray());
return TextNode.valueOf(result);
Expand Down
15 changes: 14 additions & 1 deletion core/src/test/java/com/styra/opa/wasm/OpaStringBuiltinsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ public static void beforeAll() throws Exception {
"string-builtins",
"string_builtins/invoke_sprintf",
"string_builtins/integer_fastpath",
"string_builtins/string_example")
"string_builtins/string_example",
"string_builtins/quoted")
.resolve("policy.wasm");
}

Expand Down Expand Up @@ -46,4 +47,16 @@ public void stringExample() {

assertEquals("my string", result.get("printed").asText());
}

@Test
public void quoted() {
var opa = OpaPolicy.builder().withPolicy(wasmFile).build();

var result =
Utils.getResult(
opa.entrypoint("string_builtins/quoted")
.evaluate("{\"value\": \"String\"}"));

assertEquals("requested \"String\" is invalid", result.get("printed").asText());
}
}
4 changes: 4 additions & 0 deletions core/src/test/resources/fixtures/string-builtins/policy.rego
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,7 @@ integer_fastpath := {
string_example := {
"printed": sprintf("%s", ["my string"])
}

quoted := {
"printed": sprintf("requested %q is invalid", [input.value])
}
Loading