Skip to content

Skip wpgx cache invalidation when DML affects zero rows #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaxxjj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip wpgx cache invalidation when DML affects zero rows #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion internal/codegen/golang/templates/wpgx/queryCode.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,17 @@ func (q *Queries) {{.MethodName}}(ctx context.Context, {{.Arg.Pair}} {{.Invalida
qctx, cancel := context.WithTimeout(ctx, time.Millisecond * {{.Option.Timeout.Milliseconds}})
defer cancel()
{{- end}}
_, err := q.db.WExec(qctx, "{{.UniqueLabel}}", {{.ConstantName}}, {{.Arg.Params}})
{{ if .Option.Invalidates }}cmd{{ else }}_{{ end }}, err := q.db.WExec(qctx, "{{.UniqueLabel}}", {{.ConstantName}}, {{.Arg.Params}})
if err != nil {
return err
}
{{ if .Option.Invalidates -}}
// Zero-row DML changed nothing: cached entries are still valid, skip
// invalidation. Non-row commands (e.g. TRUNCATE) report zero rows but
// do mutate state, so they always invalidate.
if cmd.RowsAffected() == 0 && (cmd.Insert() || cmd.Update() || cmd.Delete()) {
return nil
}
// invalidate
_ = q.db.PostExec(func() error {
if q.cache == nil {
Expand Down Expand Up @@ -290,6 +296,10 @@ func (q *Queries) {{.MethodName}}(ctx context.Context, {{.Arg.Pair}} {{.Invalida
return 0, err
}
{{ if .Option.Invalidates -}}
// Zero-row DML changed nothing: skip invalidation (see :exec).
if result.RowsAffected() == 0 && (result.Insert() || result.Update() || result.Delete()) {
return 0, nil
}
// invalidate
_ = q.db.PostExec(func() error {
if q.cache == nil {
Expand Down Expand Up @@ -338,6 +348,10 @@ func (q *Queries) {{.MethodName}}(ctx context.Context, {{.Arg.Pair}} {{.Invalida
return rv, err
}
{{ if .Option.Invalidates -}}
// Zero-row DML changed nothing: skip invalidation (see :exec).
if rv.RowsAffected() == 0 && (rv.Insert() || rv.Update() || rv.Delete()) {
return rv, nil
}
// invalidate
_ = q.db.PostExec(func() error {
if q.cache == nil {
Expand Down