Update docstring for fit measures#310
Open
alyst wants to merge 4 commits intoStructuralEquationModels:develfrom
Open
Update docstring for fit measures#310alyst wants to merge 4 commits intoStructuralEquationModels:develfrom
alyst wants to merge 4 commits intoStructuralEquationModels:develfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #310 +/- ##
==========================================
- Coverage 71.83% 71.39% -0.45%
==========================================
Files 51 51
Lines 2223 2283 +60
==========================================
+ Hits 1597 1630 +33
- Misses 626 653 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b60fd72 to
943291b
Compare
943291b to
ab8f627
Compare
Co-authored-by: Maximilian Ernst <34346372+Maximilian-Stefan-Ernst@users.noreply.github.com>
Comment on lines
+7
to
+11
| The degrees of freedom for the SEM with *N* observed variables is the difference | ||
| between the number of parameters required to define the multivariate normal | ||
| distribution of observed variables (*½N(N+1)* for the *N×N* covariance matrix, | ||
| plus *N* for the means vector if present), and the number of model parameters | ||
| (`nparams(model)`](@ref nparams)). |
Collaborator
There was a problem hiding this comment.
Suggested change
| The degrees of freedom for the SEM with *N* observed variables is the difference | |
| between the number of parameters required to define the multivariate normal | |
| distribution of observed variables (*½N(N+1)* for the *N×N* covariance matrix, | |
| plus *N* for the means vector if present), and the number of model parameters | |
| (`nparams(model)`](@ref nparams)). | |
| The degrees of freedom for the SEM with *N* observed variables is the difference | |
| between the number of observed data points (*½N(N+1)* for the *N×N* covariance matrix, | |
| plus *N* for the means vector if present), and the number of model parameters | |
| (`nparams(model)`](@ref nparams)). |
Collaborator
|
That's very helpful, I added on emore comment, otherwise I'm happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand a bit the docstrings for the fit measures.