Update loss checks#309
Merged
Maximilian-Stefan-Ernst merged 2 commits intoStructuralEquationModels:develfrom Feb 20, 2026
Merged
Update loss checks#309Maximilian-Stefan-Ernst merged 2 commits intoStructuralEquationModels:develfrom
Maximilian-Stefan-Ernst merged 2 commits intoStructuralEquationModels:develfrom
Conversation
don't throw an exception
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #309 +/- ##
==========================================
- Coverage 71.83% 71.68% -0.16%
==========================================
Files 51 51
Lines 2223 2239 +16
==========================================
+ Hits 1597 1605 +8
- Misses 626 634 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you! Also good to know about the indentation behaviour. |
36b88e6
into
StructuralEquationModels:devel
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR slightly tweaks the recently introduced checks that the SEM loss function uses the compatible
SemObservedobject:SemObservedMissingforSemMLandSemWLS, but shows a warning that approximate cov/mean will be used.In my use cases it is actually unfeasible to use FIML, because of the large number of observed vars and missing patterns, but EM-based approximation works quite well with SemML
SemObservedDatais tweaked to avoid generating temporary array, which could be quite largeThe correct way to define such messages is to use indented
"""strings -- the indentation of"""is subtracted from the string indentation, so they are not overindented when printed.