fix: preserve duplicate response headers#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added
Headers.getSetCookie()to return rawSet-Cookieresponse header values as an array, matching modern Node/undici-style fetch behavior.Fixed
[name, value]tuples instead of a plain object, so repeated headers are preserved.response.headers.get(name)now returns comma-joined values for repeated headers, matching fetch behavior.response.headers.get('set-cookie')now preserves all receivedSet-Cookievalues in the joined header view, whileresponse.headers.getSetCookie()andresponse.wreq.setCookiesexpose the raw cookie header array.Response.clone()now preserves duplicate response headers instead of collapsing them through object conversion.Tests
Set-Cookieheaders,Headers.getSetCookie(), and cloned responses.Build & CI
README.md,docs/**, issue templates, and skill files no longer trigger the test or native build CI workflows.🎯 Type of Change