-
Notifications
You must be signed in to change notification settings - Fork 0
Update API Client Specs to v1.2.7 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StatPan
wants to merge
1
commit into
master
Choose a base branch
from
update-api-specs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "OPENSRVAPI": [ | ||
| { | ||
| "head": [ | ||
| { | ||
| "list_total_count": 277 | ||
| }, | ||
| { | ||
| "RESULT": { | ||
| "CODE": "INFO-000", | ||
| "MESSAGE": "정상 처리되었습니다." | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "row": [ | ||
| { | ||
| "INF_ID": "OZN379001174FW17905", | ||
| "INF_NM": "NABO 경제재정수첩", | ||
| "INF_EXP": "NABO 경제재정수첩은 국내 주요한 경제통계, 재정통계, 위원회별 통계 등 다양한 정보를 제공합니다.", | ||
| "CATE_NM": "보고서ㆍ발간물>국회예산정책처", | ||
| "OPEN_DTTM": "2020-02-07", | ||
| "ORG_NM": "국회예산정책처", | ||
| "LOAD_DTTM": "2026-05-08", | ||
| "SRC_EXP": "국회예산정책처 홈페이지", | ||
| "DDC_URL": "https://open.assembly.go.kr/portal/data/openapi/downloadOpenApiSpec.do?infId=OZN379001174FW17905&infSeq=2", | ||
| "SRV_URL": "https://open.assembly.go.kr/portal/data/service/selectAPIServicePage.do/OZN379001174FW17905", | ||
| "CCL_NM": "출처표시", | ||
| "LOAD_NM": "수시", | ||
| "LOAD_CONT": "자료 발생시" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "nlhssknfaoxiofyix": [ | ||
| { | ||
| "head": [ | ||
| { | ||
| "list_total_count": 48 | ||
| }, | ||
| { | ||
| "RESULT": { | ||
| "CODE": "INFO-000", | ||
| "MESSAGE": "정상 처리되었습니다." | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "row": [ | ||
| { | ||
| "YR": "2024", | ||
| "JBTP_NM": "행정직(장애)", | ||
| "ADPT_NOP": 1, | ||
| "CMPT_RT": 19.3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "ncdawwizazvcivann": [ | ||
| { | ||
| "head": [ | ||
| { | ||
| "list_total_count": 344 | ||
| }, | ||
| { | ||
| "RESULT": { | ||
| "CODE": "INFO-000", | ||
| "MESSAGE": "정상 처리되었습니다." | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "row": [ | ||
| { | ||
| "YR": "2024", | ||
| "JBTP_NM": "속기직", | ||
| "ADPT_NOP": 2, | ||
| "CMPT_RT": 62.5 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "noahbdisawgzvhooq": [ | ||
| { | ||
| "head": [ | ||
| { | ||
| "list_total_count": 25 | ||
| }, | ||
| { | ||
| "RESULT": { | ||
| "CODE": "INFO-000", | ||
| "MESSAGE": "정상 처리되었습니다." | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "row": [ | ||
| { | ||
| "DIV_NM": "서울특별시 영등포구 여의도동", | ||
| "BLDG_NM": "국회의사당", | ||
| "ARE": "81443.84", | ||
| "FLSP": "24637", | ||
| "AMT": 25292286453, | ||
| "YR": "2024" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values for
Service.의안_접수목록andService.의안정보_통합_APIhave been changed to point to new service IDs. This is a breaking change for users of the library, as their code relying on these enum members will now call different API endpoints unexpectedly.While the old service IDs are preserved in new enum members with suffixes (e.g.,
의안_접수목록_OOWY4R001216HX11458), changing the value of an existing public enum member violates semantic versioning principles for a minor version bump and can lead to subtle bugs in consumer code.To maintain backward compatibility, I suggest keeping the original enum members pointing to their old service IDs and introducing new members for the new services. For example:
If the old endpoints are deprecated, it would be better to rename them to explicitly mark them as such (e.g.,
의안_접수목록_DEPRECATED).Since this file is auto-generated, this likely requires a change in the code generator. As a temporary measure for this PR, you could manually adjust this file to prevent this breaking change.