Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the package version to 0.6.3 in both the source code and the lock file. Feedback was provided to implement dynamic versioning using importlib.metadata to ensure a single source of truth and prevent future synchronization issues between the package metadata and the source code.
| """AssemblyMCP - MCP Server for Korean National Assembly Open API""" | ||
|
|
||
| __version__ = "0.1.0" | ||
| __version__ = "0.6.3" |
There was a problem hiding this comment.
To avoid manual synchronization between pyproject.toml and __init__.py, consider retrieving the version dynamically from the package metadata. This ensures a single source of truth and prevents the version from becoming out-of-sync in future releases, as happened previously (0.1.0 vs 0.6.3).
| __version__ = "0.6.3" | |
| from importlib.metadata import version, PackageNotFoundError | |
| try: | |
| __version__ = version("assemblymcp") | |
| except PackageNotFoundError: | |
| # Fallback if the package is not installed | |
| __version__ = "0.6.3" |
|
Closing in favor of a refreshed PR based on current master/version 0.6.4. This branch was created before the automatic version bump landed, so it is stale against current master. |
Summary
assemblymcp.__version__with the released project version0.6.3uv.lockValidation
uv run pytest -q->67 passed