Skip to content

fix: sync package version metadata#57

Closed
StatPan wants to merge 1 commit intomasterfrom
fix/sync-version-0.6.3
Closed

fix: sync package version metadata#57
StatPan wants to merge 1 commit intomasterfrom
fix/sync-version-0.6.3

Conversation

@StatPan
Copy link
Copy Markdown
Owner

@StatPan StatPan commented Mar 31, 2026

Summary

  • sync assemblymcp.__version__ with the released project version 0.6.3
  • refresh editable package version in uv.lock

Validation

  • uv run pytest -q -> 67 passed
  • real API smoke check -> bills, members, meetings, committees all returned data

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 0.6.3 in both the source code and the lock file. Feedback was provided to implement dynamic versioning using importlib.metadata to ensure a single source of truth and prevent future synchronization issues between the package metadata and the source code.

Comment thread assemblymcp/__init__.py
"""AssemblyMCP - MCP Server for Korean National Assembly Open API"""

__version__ = "0.1.0"
__version__ = "0.6.3"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid manual synchronization between pyproject.toml and __init__.py, consider retrieving the version dynamically from the package metadata. This ensures a single source of truth and prevents the version from becoming out-of-sync in future releases, as happened previously (0.1.0 vs 0.6.3).

Suggested change
__version__ = "0.6.3"
from importlib.metadata import version, PackageNotFoundError
try:
__version__ = version("assemblymcp")
except PackageNotFoundError:
# Fallback if the package is not installed
__version__ = "0.6.3"

@StatPan
Copy link
Copy Markdown
Owner Author

StatPan commented Mar 31, 2026

Closing in favor of a refreshed PR based on current master/version 0.6.4. This branch was created before the automatic version bump landed, so it is stale against current master.

@StatPan StatPan closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant