Fix conversions between axial and offset hex coords#416
Open
rparrett wants to merge 3 commits intoStarArawn:mainfrom
Open
Fix conversions between axial and offset hex coords#416rparrett wants to merge 3 commits intoStarArawn:mainfrom
rparrett wants to merge 3 commits intoStarArawn:mainfrom
Conversation
Collaborator
Author
|
I uncommented the stuff in the CI workflow that actually runs tests. |
Collaborator
Author
|
I can't remember if some of these offsets should differ from redblob's numbers due to bevy's coordinate system or whatever. We should double check that before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #414
This fixes conversions between
AxialPosand (RowEvenPos,RowOddPos,ColEvenPos,ColOddPos) when coordinates are negative.See https://www.redblobgames.com/grids/hexagons/#conversions
This seems correct, but it's currently unclear to me if similar work needs to be done in the shaders.