Skip to content

[BUG FIX] The scanning progress overlay is fixed to be static#182

Closed
Annunitha wants to merge 2 commits into
Stanzin7:masterfrom
Annunitha:overlayfix
Closed

[BUG FIX] The scanning progress overlay is fixed to be static#182
Annunitha wants to merge 2 commits into
Stanzin7:masterfrom
Annunitha:overlayfix

Conversation

@Annunitha

Copy link
Copy Markdown
Contributor

Before
Screenshot 2026-04-04 100935

As seen above, the progress overlay lays on top of the page footer when the user scrolls down.

After
Screenshot 2026-04-04 221049

The bug has been fixed to make sure the div stays static and does not move with scrolling.

File changed: ScanProgressPage.scss

Fixes issue: #168

@Annunitha Annunitha marked this pull request as draft April 4, 2026 17:08
@Annunitha Annunitha marked this pull request as ready for review April 4, 2026 17:21
@sapnilbiswas

Copy link
Copy Markdown
Contributor

Thanks @Annunitha the fix looks good already. But can you try and make the scanning div as overlay along with the footer being blurred while it's scrolled?

@Annunitha

Copy link
Copy Markdown
Contributor Author

@sapnilbiswas Alright, I'll do that. I'll keep you updated!

@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ec9e4b7f-98b2-448b-8f2b-5aee8cbdcd8d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@sapnilbiswas

Copy link
Copy Markdown
Contributor

@Annunitha any updates?

@Stanzin7

Copy link
Copy Markdown
Owner

Thanks @Annunitha for tackling #168. The core intent is only addressed by one line here (ScanProgressPage.scss:15, position: fixed → relative), and even that leaves a now-dead inset: 0; the other ~9 edits change unrelated layout and risk regressions. More importantly, #168 itself is superseded — starting a scan now navigates to a dedicated /scan/progress/:scanId route (ScanContext.jsx:197,245) instead of overlaying the homepage, so the original overlay bug no longer exists. Recommending we close both this PR and #168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants