Fix: Align CompressedBinaryIBLExtractor with updated get_neuropixels_sample_shifts s…#4477
Open
hayleybounds wants to merge 1 commit intoSpikeInterface:mainfrom
Open
Fix: Align CompressedBinaryIBLExtractor with updated get_neuropixels_sample_shifts s…#4477hayleybounds wants to merge 1 commit intoSpikeInterface:mainfrom
hayleybounds wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
…ignature The CompressedBinaryIblExtractor was still using a multi-argument call to get_neuropixels_sample_shifts_from_probe, which now only accepts a single probe argument. Also removes issues with missing probe_type annotation by removing redundant num_channels_per_adc calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CompressedBinaryIblExtractor was still using a multi-argument call to get_neuropixels_sample_shifts_from_probe, which now only accepts a single probe argument. Also removes issues with missing probe_type annotation by removing the now-unused num_channels_per_adc calculation.