Better handling of scroll time in trace viewer#256
Merged
alejoe91 merged 3 commits intoSpikeInterface:mainfrom Mar 23, 2026
Merged
Better handling of scroll time in trace viewer#256alejoe91 merged 3 commits intoSpikeInterface:mainfrom
alejoe91 merged 3 commits intoSpikeInterface:mainfrom
Conversation
alejoe91
reviewed
Mar 23, 2026
spikeinterface_gui/traceview.py
Outdated
| def _qt_update_scroll_step(self): | ||
| segment_index = self.controller.get_time()[1] | ||
| length = self.controller.get_num_samples(segment_index) | ||
| self.scrool_step = length / 2**16 |
Member
There was a problem hiding this comment.
Suggested change
| self.scrool_step = length / 2**16 | |
| self.scroll_step = length / 2**16 |
alejoe91
reviewed
Mar 23, 2026
spikeinterface_gui/traceview.py
Outdated
|
|
||
| def _qt_on_scroll_time(self, val): | ||
| time = self.controller.sample_index_to_time(val) | ||
| sample = val * self.scrool_step |
Member
There was a problem hiding this comment.
Suggested change
| sample = val * self.scrool_step | |
| sample = val * self.scroll_step |
alejoe91
approved these changes
Mar 23, 2026
alejoe91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix this #253.
@JoeZiminski
Here I chosse a fix step of total duration per segment / 2**16
This avoid the clipping.
Can you test it of your very long recording ?