Skip to content

YT-CPPGL-68: Implement missing vertex view getters #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpectraL519 merged 9 commits into from
Apr 10, 2026
Merged

YT-CPPGL-68: Implement missing vertex view getters #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
afa40f0
initial vertex getters impl + impl classes layout refinement
SpectraL519 Apr 10, 2026
948c7f7
tests layout refinement
SpectraL519 Apr 10, 2026
abef96d
move this shit around
SpectraL519 Apr 10, 2026
5539241
incident_edges directed logic error fix
SpectraL519 Apr 10, 2026
ee36c8a
incident_edges tests for adj models
SpectraL519 Apr 10, 2026
59d480d
are_incident -> are_adjacent for (v,v) and (e,e)
SpectraL519 Apr 10, 2026
14b9a1d
new vertex getters tests (impl)
SpectraL519 Apr 10, 2026
c7053d5
new vertex getters tests (graph)
SpectraL519 Apr 10, 2026
8b2245c
resolved comments by gemini
SpectraL519 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/suites/is_bipartite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <gl/algorithm.hpp>
#include <gl/graph.hpp>
#include <gl/topologies.hpp>
#include <gl/topology.hpp>

#include <benchmark/benchmark.h>

Expand Down
2 changes: 1 addition & 1 deletion include/gl/algorithm/spanning_tree/prim_mst.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ template <traits::c_undirected_graph G>
if (root_id == invalid_id)
root_id = initial_id;

for (const auto& edge : graph.incident_edges(root_id))
for (const auto& edge : graph.out_edges(root_id))
edge_queue.emplace(edge);

// mark the root vertex as visited
Expand Down
2 changes: 1 addition & 1 deletion include/gl/algorithm/templates/bfs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ bool bfs(
if (not visit(node.vertex_id, node.pred_id))
return false;

for (const auto& edge : graph.incident_edges(node.vertex_id)) {
for (const auto& edge : graph.out_edges(node.vertex_id)) {
const auto target_vertex_id = edge.other(node.vertex_id);
const auto enqueue = enqueue_vertex_pred(target_vertex_id, edge);
if (enqueue == decision::abort)
Expand Down
4 changes: 2 additions & 2 deletions include/gl/algorithm/templates/dfs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ bool dfs(
if (not visit(node.vertex_id, node.pred_id))
return false;

for (const auto& edge : graph.incident_edges(node.vertex_id)) {
for (const auto& edge : graph.out_edges(node.vertex_id)) {
const auto target_vertex_id = edge.other(node.vertex_id);
if (enqueue_vertex_pred(target_vertex_id, edge))
s.emplace(target_vertex_id, node.vertex_id);
Expand Down Expand Up @@ -96,7 +96,7 @@ void r_dfs(
visit(vertex_id, pred_id);

// recursively search vertices adjacent to the current vertex
for (const auto& edge : graph.incident_edges(vertex_id)) {
for (const auto& edge : graph.out_edges(vertex_id)) {
const auto target_vertex_id = edge.other(vertex_id);
if (enqueue_vertex_pred(target_vertex_id, edge))
r_dfs(
Expand Down
2 changes: 1 addition & 1 deletion include/gl/algorithm/templates/pfs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ bool pfs(
if (not visit(node.vertex_id, node.pred_id))
return false;

for (const auto& edge : graph.incident_edges(node.vertex_id)) {
for (const auto& edge : graph.out_edges(node.vertex_id)) {
const auto target_vertex_id = edge.other(node.vertex_id);
const auto enqueue = enqueue_vertex_pred(target_vertex_id, edge);
if (enqueue == decision::abort)
Expand Down
Loading
Loading