Collect or skip custom deny aces count#218
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR adds a new ChangesSkipDenyAcesCount Feature Implementation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Adds SharpHound support for custom deny ACE count collection from SharpHoundCommon.
This wires the new
LdapConfig.SkipDenyAcesCountsetting into SharpHound, exposes the matching--skipdenyacescountCLI option, and updates the PowerShell wrapper and README help text to use the count-oriented name.Motivation and Context
SharpHoundCommon now reports custom explicit and inherited deny ACE counts as LDAP object properties. SharpHound needs to pass through the opt-out setting so operators can skip that collection path when desired.
This PR addresses: BED-8117
Related PRs:
BloodHound: SpecterOps/BloodHound#2779
SharpHoundCommon: SpecterOps/SharpHoundCommon#298
SharpHoundEnterprise: https://github.com/SpecterOps/sharphound-enterprise/pull/113
How Has This Been Tested?
Tested locally against the sibling
SharpHoundCommonBED-8117-deny-acesbranch using local DLL references.Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit
New Features
--skipdenyacescountcommand-line argument to skip collection of custom deny Access Control Entry (ACE) counts from LDAP object properties during enumeration.-SkipDenyAcesCountPowerShell switch parameter for PowerShell-based enumeration workflows.Documentation