Skip to content

fix: adjust text equality to force index matching on indexes - BED-8505#92

Merged
zinic merged 1 commit into
stage/v0.5.5from
index-regression-cherrypick
May 29, 2026
Merged

fix: adjust text equality to force index matching on indexes - BED-8505#92
zinic merged 1 commit into
stage/v0.5.5from
index-regression-cherrypick

Conversation

@zinic
Copy link
Copy Markdown
Contributor

@zinic zinic commented May 29, 2026

Description

  • Add jsonb_typeof SQL function identifier
  • Route text property equality away from JSONB casts
  • Add string property equality predicate builders
  • Apply string equality rewrite during expression lowering
  • Update SQL fixtures for indexed text equality
  • Add synthetic reconciliation index stress test
  • Update text equality rewrite unit expectation

Resolves: BED-8505

Type of Change

  • Chore (a change that does not modify the application functionality)
  • Bug fix (a change that fixes an issue)
  • New feature / enhancement (a change that adds new functionality)
  • Refactor (no behaviour change)
  • Test coverage
  • Build / CI / tooling
  • Documentation

Testing

  • Unit tests added / updated
  • Integration tests added / updated
  • Full test suite run (make test_all with CONNECTION_STRING set)

Driver Impact

  • PostgreSQL driver (drivers/pg)
  • Neo4j driver (drivers/neo4j)

Checklist

  • Code is formatted
  • All existing tests pass
  • go.mod / go.sum are up to date if dependencies changed

…ndexes

- Add jsonb_typeof SQL function identifier
- Route text property equality away from JSONB casts
- Add string property equality predicate builders
- Apply string equality rewrite during expression lowering
- Update SQL fixtures for indexed text equality
- Add synthetic reconciliation index stress test
- Update text equality rewrite unit expectation
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c14cf5c3-0139-409b-8992-14db16461cc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch index-regression-cherrypick

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zinic zinic merged commit a699728 into stage/v0.5.5 May 29, 2026
7 of 8 checks passed
@zinic zinic changed the title fix(cysql): adjust text equality to force index matching on trigram i… fix: adjust text equality to force index matching on indexes - BED-8505 May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants