Add test for Execute #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack3rs
reviewed
Aug 19, 2025
| context.Background(), | ||
| `SELECT name FROM test ORDER BY id DESC LIMIT 1`, | ||
| ).Scan(&queriedName) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
This is ace! :-) Thank you! .. In this bit can you have a go at using the QueryStruct and QuerySingleStuct to get the data, we get more test coverage then. Maybe use both methods and make sure they both return the same thing?
Contributor
There was a problem hiding this comment.
Add yourself a task for this if you like. I'd rather not hold up the PR.
ack3rs
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small test for the Execute GSDB function
I'm sure there's some clean ups / effiency chances that can be done here, such as auto incrementing the test case IDs rather than manually setting them to +1 of the previous case. Let me know if you have any ideas