socket implementation#21
Draft
miDeb wants to merge 3 commits into
Draft
Conversation
Member
|
I just had a quick look at it and I think we should focus on the interface and get that stable before improving the implementation. That way @luis can work on the ecui part while we improve the rest. We can talk about it in the evening as well |
Merged
- load mappings from a directory - change mapping to be grouped by node - simplify some code
raffael0
force-pushed
the
feat/webserver-socket-protocol
branch
from
c48196d to
e771287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #16, the changes to that are in the latest commit here. I'm still not 100% happy with the implementation, in particular the snapshotting logic. It's currently a bit vibe-coded and allocates way too much in my opinion, but I have to look up how to best improve that (probably custom implementation of Serialize).