Update Twitter username description to 'X username' + Instagram#132
Update Twitter username description to 'X username' + Instagram#132iooner wants to merge 1 commit intoSpaceApi:masterfrom
Conversation
Update Twitter username description to 'X username' in desc and add instagram feed
| "instagram": { | ||
| "description": "URL to Instagram profile", | ||
| "type": "string", | ||
| "examples": [ | ||
| "https://www.instagram.com/examplespace" | ||
| ] | ||
| } |
There was a problem hiding this comment.
While I'm not a fan of Instagram at all (since the Meta takeover), I can see that some spaces might have an account. As such, it probably makes sense to add it to the schema.
There was a problem hiding this comment.
At the moment, a total of 7 spaces in the directory list an Instagram account as contact.instagram or contact.ext_instagram. A slight majority seems to go by URL rather than account name only:
"ext_instagram": "leighhackspace"
"instagram": "https://www.instagram.com/netz_39/"
"instagram": "https://www.instagram.com/farsetlabs"
"instagram": "https://www.instagram.com/hackspace_siegen/"
"instagram": "segvaultspace"
"instagram": "https://www.instagram.com/hack.manhattan/"
"instagram": "@MakeSpaceMadrid"
I'm in favor of going with the URL over username only.
| "twitter": { | ||
| "description": "Twitter username with leading <code>@</code>", | ||
| "description": "X username with leading <code>@</code>", | ||
| "type": "string", | ||
| "examples": [ | ||
| "@space_api" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
We should probably deprecate the twitter key below keymasters, it doesn't really make sense there.
What do you think, @SpaceApi/core?
There was a problem hiding this comment.
That will break backward compatibility with previous versions of the API.
There was a problem hiding this comment.
That will break backward compatibility with previous versions of the API.
Our policy is to deprecate things in version x and then remove them in x+1. The reason we have a versioned API is that we have breaking changes from time to time.
| "twitter": { | ||
| "description": "Twitter username with leading <code>@</code>", | ||
| "description": "X username with leading <code>@</code>", | ||
| "type": "string", | ||
| "examples": [ | ||
| "@space_api" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
We should also deprecate the twitter key as well and add a new x or x.com key.
There was a problem hiding this comment.
If we change this, I'd definitely prefer x.com over x, both in the key and in the description (or something like X (formerly Twitter)). A single letter is far too overloaded, and not everyone will think of that platform when reading "x". E.g. personally, if someone tells me "they're using X", my first thought is the Linux window system 🙃
s3lph
left a comment
s3lph
left a comment
There was a problem hiding this comment.
Any changes done in this PR also need to be reflected in the changelog.
4 participants
Update Twitter username description to 'X username' in desc and add instagram feed